Date: Wed, 18 Nov 2015 13:11:42 -0500
From: Tejun Heo <tj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Yang Shi <yang.shi@linaro.org>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] writeback: initialize m_dirty to avoid compile warning
Message-ID: <20151118181142.GC11496@mtj.duckdns.org>
References: <1447439201-32009-1-git-send-email-yang.shi@linaro.org>
 <20151117153855.99d2acd0568d146c29defda5@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151117153855.99d2acd0568d146c29defda5@linux-foundation.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1349
Lines: 40

Hello,

On Tue, Nov 17, 2015 at 03:38:55PM -0800, Andrew Morton wrote:
> > --- a/mm/page-writeback.c
> > +++ b/mm/page-writeback.c
> > @@ -1542,7 +1542,7 @@ static void balance_dirty_pages(struct address_space *mapping,
> >  	for (;;) {
> >  		unsigned long now = jiffies;
> >  		unsigned long dirty, thresh, bg_thresh;
> > -		unsigned long m_dirty, m_thresh, m_bg_thresh;
> > +		unsigned long m_dirty = 0, m_thresh = 0, m_bg_thresh = 0;
> >  
> >  		/*
> >  		 * Unstable writes are a feature of certain networked
> 
> Adding runtime overhead to suppress a compile-time warning is Just
> Wrong.
> 
> With gcc-4.4.4 the above patch actually reduces page-writeback.o's
> .text by 36 bytes, lol.  With gcc-4.8.4 the patch saves 19 bytes.  No
> idea what's going on there...
> 
> 
> And initializing locals in the above fashion can hide real bugs -
> looky:

This was the main reason the code was structured the way it is.  If
cgroup writeback is not enabled, any derefs of mdtc variables should
trigger warnings.  Ugh... I don't know.  Compiler really should be
able to tell this much.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/