Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756617AbbKRS3a (ORCPT ); Wed, 18 Nov 2015 13:29:30 -0500 Received: from mail-ig0-f177.google.com ([209.85.213.177]:38267 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751600AbbKRS32 (ORCPT ); Wed, 18 Nov 2015 13:29:28 -0500 MIME-Version: 1.0 In-Reply-To: <4370741.70D0kgBgnp@wuerfel> References: <4370741.70D0kgBgnp@wuerfel> Date: Wed, 18 Nov 2015 12:29:27 -0600 Message-ID: Subject: Re: [PATCH] usb: musb: USB_TI_CPPI41_DMA requires dmaengine support From: Bin Liu To: Arnd Bergmann Cc: balbi@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , George Cherian , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1755 Lines: 48 Hi, On Wed, Nov 18, 2015 at 10:18 AM, Arnd Bergmann wrote: > The CPPI-4.1 driver selects TI_CPPI41, which is a dmaengine > driver and that may not be available when CONFIG_DMADEVICES > is not set: > > warning: (USB_TI_CPPI41_DMA) selects TI_CPPI41 which has unmet direct dependencies (DMADEVICES && ARCH_OMAP) > > This adds an extra dependency to avoid generating warnings in randconfig > builds. Ideally we'd remove the 'select' statement, but that has the > potential to break defconfig files. > > Signed-off-by: Arnd Bergmann > Fixes: 411dd19c682d ("usb: musb: Kconfig: Select the DMA driver if DMA mode of MUSB is enabled") > > diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig > index 1f2037bbeb0d..45c83baf675d 100644 > --- a/drivers/usb/musb/Kconfig > +++ b/drivers/usb/musb/Kconfig > @@ -159,7 +159,7 @@ config USB_TI_CPPI_DMA > > config USB_TI_CPPI41_DMA > bool 'TI CPPI 4.1 (AM335x)' > - depends on ARCH_OMAP > + depends on ARCH_OMAP && DMADEVICES > select TI_CPPI41 I am not sure what the generic policy is, but instead of hiding USB_TI_CPPI41_DMA if DMADEVICES is disabled, I'd like to enable DMADEVICES if USB_TI_CPPI41_DMA is enabled, from user experience perspective. Thanks, -Bin. > > config USB_TUSB_OMAP_DMA > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/