Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756710AbbKRSw4 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Nov 2015 13:52:56 -0500
Received: from shards.monkeyblade.net ([149.20.54.216]:51609 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752988AbbKRSwx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Nov 2015 13:52:53 -0500
Date: Wed, 18 Nov 2015 13:52:50 -0500 (EST)
Message-Id: <20151118.135250.2066223916643044258.davem@davemloft.net>
To: salil.mehta@huawei.com
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
        paul.gortmaker@windriver.com, ijc+devicetree@hellion.org.uk,
        galak@codeaurora.org, catalin.marinas@arm.com, will.deacon@arm.com,
        arnd@arndb.de, liguozhu@hisilicon.com, yisen.zhuang@huawei.com,
        dingtianhong@huawei.com, zhangfei.gao@linaro.org,
        huangdaode@hisilicon.com, kenneth-lee-2012@foxmail.com,
        mehta.salil.lnk@gmail.com, xuwei5@hisilicon.com, lisheng011@huawei.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
        linuxarm@huawei.com, yankejian@huawei.com, lipeng321@huawei.com,
        fengguang.wu@intel.com
Subject: Re: [PATCH V2 net-next 1/5] net:hns: Add support of Hip06 SoC to
 the Hislicon Network Subsystem
From: David Miller <davem@davemloft.net>
In-Reply-To: <1447786347-147518-2-git-send-email-salil.mehta@huawei.com>
References: <1447786347-147518-1-git-send-email-salil.mehta@huawei.com>
	<1447786347-147518-2-git-send-email-salil.mehta@huawei.com>
X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 18 Nov 2015 10:52:53 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 727
Lines: 20

From: Salil <salil.mehta@huawei.com>
Date: Wed, 18 Nov 2015 02:52:23 +0800

> @@ -387,19 +409,23 @@ static void hns_rcb_ring_get_cfg(struct hnae_queue *q, int ring_type)
>  	struct rcb_common_cb *rcb_common;
>  	struct ring_pair_cb *ring_pair_cb;
>  	u32 buf_size;
> -	u16 desc_num;
> -	int irq_idx;
> +	u16 desc_num, mdnum_ppkt;
> +	int irq_idx, is_ver1;

Please use "bool" and true/false for boolean conditions like is_ver1.

Please audit your entire submission for this problem.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/