Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756688AbbKRTTG (ORCPT ); Wed, 18 Nov 2015 14:19:06 -0500 Received: from mail-yk0-f170.google.com ([209.85.160.170]:35497 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755655AbbKRTTD (ORCPT ); Wed, 18 Nov 2015 14:19:03 -0500 MIME-Version: 1.0 In-Reply-To: <564CCAC2.5050600@fb.com> References: <1447856703-2566-1-git-send-email-jbacik@fb.com> <20151118184038.GA4462@localhost> <564CCAC2.5050600@fb.com> Date: Wed, 18 Nov 2015 11:19:02 -0800 Message-ID: Subject: Re: [PATCH] pci: completely disable aspm if it's unsupported From: Matthew Garrett To: Josef Bacik Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, Linux Kernel Mailing List , linux-acpi@vger.kernel.org, Bjorn Helgaas , shli@fb.com, kernel-team@fb.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 836 Lines: 15 On Wed, Nov 18, 2015 at 11:00 AM, Josef Bacik wrote: > It looks to me I'm doing what Matthew set out to do, only with a bigger > hammer ;). His patch still allowed the initialization of the ASPM stuff, > like setting up the clocks and such, but then made it so we couldn't change > the ASPM state at all. My patch goes the step further of not even doing the > initialization stuff. Thanks, That sounds fine - if we don't gain _OSC control then we should avoid touching any of the ASPM register state that the firmware has set. I'm happy to call the current state broken. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/