Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756807AbbKRT2K (ORCPT ); Wed, 18 Nov 2015 14:28:10 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:39830 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754619AbbKRT2H (ORCPT ); Wed, 18 Nov 2015 14:28:07 -0500 From: Felipe Balbi To: Bin Liu , Arnd Bergmann CC: , , Greg Kroah-Hartman , Subject: Re: [PATCH] usb: musb: USB_TI_CPPI41_DMA requires dmaengine support In-Reply-To: References: <4370741.70D0kgBgnp@wuerfel> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 18 Nov 2015 13:27:32 -0600 Message-ID: <87a8qbhzvf.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2639 Lines: 72 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Bin Liu writes: > On Wed, Nov 18, 2015 at 10:18 AM, Arnd Bergmann wrote: >> The CPPI-4.1 driver selects TI_CPPI41, which is a dmaengine >> driver and that may not be available when CONFIG_DMADEVICES >> is not set: >> >> warning: (USB_TI_CPPI41_DMA) selects TI_CPPI41 which has unmet direct de= pendencies (DMADEVICES && ARCH_OMAP) >> >> This adds an extra dependency to avoid generating warnings in randconfig >> builds. Ideally we'd remove the 'select' statement, but that has the >> potential to break defconfig files. >> >> Signed-off-by: Arnd Bergmann >> Fixes: 411dd19c682d ("usb: musb: Kconfig: Select the DMA driver if DMA m= ode of MUSB is enabled") >> >> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig >> index 1f2037bbeb0d..45c83baf675d 100644 >> --- a/drivers/usb/musb/Kconfig >> +++ b/drivers/usb/musb/Kconfig >> @@ -159,7 +159,7 @@ config USB_TI_CPPI_DMA >> >> config USB_TI_CPPI41_DMA >> bool 'TI CPPI 4.1 (AM335x)' >> - depends on ARCH_OMAP >> + depends on ARCH_OMAP && DMADEVICES >> select TI_CPPI41 > > I am not sure what the generic policy is, but instead of hiding > USB_TI_CPPI41_DMA if DMADEVICES is disabled, I'd like to enable > DMADEVICES if USB_TI_CPPI41_DMA is enabled, from user experience > perspective. that would mean "select DMADEVICES" and that's frowned upon. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWTNElAAoJEIaOsuA1yqREyzsP/jAS5p7CxR9JeCBEdDokOET1 K0m7QcUpGzbhsn6ZjdD3nho/flh1QuHFf+9/ZBnBc4UTfLzRNDX50fJ1KunM1e5w S/0ih+nAswDsXsLsPcVrsfJ3bfTfonVBpFDC4Z5rc0y/2jsXBhtTgVp8LZS7G4Sg 1ZoFptRK/M5F3iA2w/4wtYql5lMDMk/ALP3RaA31458vQCwVRD3RQLQ/6Qq/GCG0 IR5NSFrddz0n0Yc4O08byClBP8JtAvS2V66ev6j2rWIKFS8IzchyeVGR0uk+wGq0 5JLJso5GTmHJ42tIrZL9vWHPjj5txGhRjqaMFt9qx4jbaMz4RpHldSUcHjKXGrwD +cylhlu2lbQiWbsqjfyO6Tpi12zy3Q1KWPN1fCwrxujjEmHIgiqbE1KJKRvrI3Br M90TCu4g0whQ5cA+pbMpTHrKZCJ/Ei9CQ56DXB9obLE5w824OvwaMFy85KiOiQU2 rKrI8MQHUVayj+ORwvOGKZodATPm02d5Z0G4lJIydOx2T+XqambZLPavHRXOqCHM qjT2XoFRMN5N38BBfc6PiFIYyCa0JzpRpKQBxvnsZupFv2dKhfP1EdDLtrN6fAZK 9kZ7lJhwaqGTrotaEHtMLc9WcR9QZDc+OUGOPtPktlRqg27leVCq7h8kQDZ+I++v z8zgSQEt39QRbYexfsdm =5xBn -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/