Date: Wed, 18 Nov 2015 23:36:20 +0300
From: Yury Norov <ynorov@caviumnetworks.com>
To: Arnd Bergmann <arnd@arndb.de>
CC: <linux-arm-kernel@lists.infradead.org>, <catalin.marinas@arm.com>,
        <linux-kernel@vger.kernel.org>, <pinskia@gmail.com>,
        <Prasun.Kapoor@caviumnetworks.com>, <schwab@suse.de>,
        <Nathan_Lynch@mentor.com>, <agraf@suse.de>, <klimov.linux@gmail.com>,
        <broonie@kernel.org>, <jan.dakinevich@gmail.com>,
        <ddaney.cavm@gmail.com>, <bamvor.zhangjian@huawei.com>,
        <philipp.tomsich@theobroma-systems.com>, <andrey.konovalov@linaro.org>,
        <joseph@codesourcery.com>, <christoph.muellner@theobroma-systems.com>
Subject: Re: [PATCH v6 16/19] aarch64: ilp32: use generic stat64 structure
Message-ID: <20151118203620.GC11264@yury-N73SV>
References: <1447795019-30176-1-git-send-email-ynorov@caviumnetworks.com>
 <1447795019-30176-17-git-send-email-ynorov@caviumnetworks.com>
 <4020528.IPMzSqapue@wuerfel>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <4020528.IPMzSqapue@wuerfel>
User-Agent: Mutt/1.5.23 (2014-03-12)
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2015 20:36:40.3235 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR07MB622
X-Microsoft-Exchange-Diagnostics: 1;DM2PR07MB367;2:UPrTGCCfx1NwNXYZ88nmZSwxM8whZW5uvcMuwgi38EjhQOk7FgybKQshRr/4yZ9X7W1Q8cGkqcs8/tMcYywaALRgCcOjpy1XnA9haVCpAOQ4mk8dfRbqxKpnUOISVzL7ZpIL6p1ZRtQx3Ju4S9Jbxe8NxyD82NnSYjADmTCbBag=;23:O8lewpor+rf/eX7Bns+aBIZhuZksnSEi3LvrjAKFK9oBRwXKJ+hF85le4fgLAszwYYir8psP65wps44sl8dTIM7PXqmRRpxdYH7cfoqd66S97RdPgJde7uymTwuPmFoj6LcSzDup79dAhXzOTzybAKtLlFVBQLLxbpYVCMg3qpsJP6Ya9dKGR8RHF3tVRhWV
X-OriginatorOrg: caviumnetworks.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2228
Lines: 75

On Tue, Nov 17, 2015 at 11:09:05PM +0100, Arnd Bergmann wrote:
> On Wednesday 18 November 2015 00:16:56 Yury Norov wrote:
> > Generic 32-bit and AARCH32 stat64 structures has same names.
> > ILP32 needs generic stat64. So we can either make ILP32 mutual
> > exclusive with AARCH32, or duplicate generic cp_new_stat64 code
> > and struct stat64 to sys_ilp32.c. We choose second because it's
> > more flexible to have independend support for ABIs.
> > 
> 
> I commented on the previous version, but you have not replied to that,
> or changed anything.
> 
> 	Arnd

Hi Arnd,

It seems I misunderstood you.

Are you OK if we'll enable __ARCH_WANT_COMPAT_STAT64
for ILP32, as for AARCH32_EL0, and turn glibc to use
struct stat from sysdeps/unix/sysv/linux/bits/stat.h
with this calls? It seems, this is how ARM ABI works.

Yury.

---
 arch/arm64/include/asm/stat.h   | 2 --
 arch/arm64/include/asm/unistd.h | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm64/include/asm/stat.h b/arch/arm64/include/asm/stat.h
index af04276..15e3559 100644
--- a/arch/arm64/include/asm/stat.h
+++ b/arch/arm64/include/asm/stat.h
@@ -22,7 +22,6 @@
 
 #include <asm/compat.h>
 
-#ifdef CONFIG_AARCH32_EL0
 /*
  * struct stat64 is needed for compat tasks only. Its definition is different
  * from the generic struct stat64.
@@ -60,4 +59,3 @@ struct stat64 {
 
 #endif
 #endif
-#endif
diff --git a/arch/arm64/include/asm/unistd.h b/arch/arm64/include/asm/unistd.h
index 696e638..3b196f3 100644
--- a/arch/arm64/include/asm/unistd.h
+++ b/arch/arm64/include/asm/unistd.h
@@ -19,7 +19,6 @@
 #endif
 #ifdef CONFIG_AARCH32_EL0
 #define __ARCH_WANT_COMPAT_SYS_GETDENTS64
-#define __ARCH_WANT_COMPAT_STAT64
 #define __ARCH_WANT_SYS_GETHOSTNAME
 #define __ARCH_WANT_SYS_PAUSE
 #define __ARCH_WANT_SYS_GETPGRP
@@ -42,6 +41,7 @@
 #define __NR_compat_sigreturn		119
 #define __NR_compat_rt_sigreturn	173
 
+#define __ARCH_WANT_COMPAT_STAT64
 #define __ARCH_WANT_SYS_LLSEEK
 
 /*
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/