Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756948AbbKRUjL (ORCPT ); Wed, 18 Nov 2015 15:39:11 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:44221 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755252AbbKRUjK (ORCPT ); Wed, 18 Nov 2015 15:39:10 -0500 From: Felipe Balbi To: Bin Liu CC: Arnd Bergmann , , , Greg Kroah-Hartman , Subject: Re: [PATCH] usb: musb: USB_TI_CPPI41_DMA requires dmaengine support In-Reply-To: References: <4370741.70D0kgBgnp@wuerfel> <87a8qbhzvf.fsf@saruman.tx.rr.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 18 Nov 2015 14:38:36 -0600 Message-ID: <87y4dvgi0j.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3241 Lines: 96 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Bin Liu writes: >> Bin Liu writes: >>> On Wed, Nov 18, 2015 at 10:18 AM, Arnd Bergmann wrote: >>>> The CPPI-4.1 driver selects TI_CPPI41, which is a dmaengine >>>> driver and that may not be available when CONFIG_DMADEVICES >>>> is not set: >>>> >>>> warning: (USB_TI_CPPI41_DMA) selects TI_CPPI41 which has unmet direct = dependencies (DMADEVICES && ARCH_OMAP) >>>> >>>> This adds an extra dependency to avoid generating warnings in randconf= ig >>>> builds. Ideally we'd remove the 'select' statement, but that has the >>>> potential to break defconfig files. >>>> >>>> Signed-off-by: Arnd Bergmann >>>> Fixes: 411dd19c682d ("usb: musb: Kconfig: Select the DMA driver if DMA= mode of MUSB is enabled") >>>> >>>> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig >>>> index 1f2037bbeb0d..45c83baf675d 100644 >>>> --- a/drivers/usb/musb/Kconfig >>>> +++ b/drivers/usb/musb/Kconfig >>>> @@ -159,7 +159,7 @@ config USB_TI_CPPI_DMA >>>> >>>> config USB_TI_CPPI41_DMA >>>> bool 'TI CPPI 4.1 (AM335x)' >>>> - depends on ARCH_OMAP >>>> + depends on ARCH_OMAP && DMADEVICES >>>> select TI_CPPI41 >>> >>> I am not sure what the generic policy is, but instead of hiding >>> USB_TI_CPPI41_DMA if DMADEVICES is disabled, I'd like to enable >>> DMADEVICES if USB_TI_CPPI41_DMA is enabled, from user experience >>> perspective. >> >> that would mean "select DMADEVICES" and that's frowned upon. > > Currently 'select DMADEVICES' is not in there. Will adding it fix the > dependency warning in randconfig? Sorry for the question, but I don't > know enough about Kconfig to get the answer. it certainly would, but we don't like to add "select XYZ" to Kconfig because a select bypasses the dependency tree. Let me explain: config A tristate "A" depends on B config B tristate "B" config C tristate "C" select A C can select A without B being enabled. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWTOHNAAoJEIaOsuA1yqRED0cQAJJWs7OvShCHTD6eYEWWy2ku DyQ6D5kQ1q9J623uLhicu0uNVdbcXtnzboipGnes85HgZj9xrjR4b/3k2PIXcvqH XkgP7oEDoSbUQtZ6v9lVQoWrK3aH26W4tzOtgrfaiP68t63iR7QJlllK7CjDnA9c Z0SX97+ELbfyJCuYrCqym33S6cRGfKbj7qvSqVcWkr4HxUqP/Z1KdhZQaz8w6a8A Q3YEq3tQgnXcmnXPxNKsdHt1Ow89pwZ/Xn1+E5+dAnovQ+rBSusO4/AOJTNnpEcc r2EvYXfCIJP9yjEzlVsYc7JE8HymMSjXh/YwSZM7jb0cgy7/3y+ojn0QEG6/Xpaj P+2BgSKm+KL0UiLmlmtAgkn9s8IDU3xYV8CkgvWxDyDWNI9XvADFjPkSaDPeS584 XNrWY69RfR+qg6mP6MTyzUQSXTqwSoSiRdnLKck/zbuSPD4NdE8EcJqqpQjwHvVc MUHTZpAI1IXU1G3V1Rp+Y9P9M1tF/QCob1Q+4zjzrhe84WUyXxvqVKHSRIZVjQD0 2FFrokRZxg+/YrXjgDNlv1i3OLqKMX9n7p3Wb04kfF7OchQiAjn3jMyitJd2ZBbU RYdF/zDQPTvhxeDHLkGdrCsV9W4qFcub8HxQAYozK/9xVp5xAJIeDBCzGriYBcQT Ehn4l9Bh4MuAVJwprLcU =WNQu -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/