Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933103AbbKRUmJ (ORCPT ); Wed, 18 Nov 2015 15:42:09 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:42789 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755483AbbKRUmH (ORCPT ); Wed, 18 Nov 2015 15:42:07 -0500 From: Felipe Balbi To: Arnd Bergmann , CC: Bin Liu , Greg Kroah-Hartman , , Subject: Re: [PATCH] usb: musb: USB_TI_CPPI41_DMA requires dmaengine support In-Reply-To: <3958456.qUtBLJFy2S@wuerfel> References: <4370741.70D0kgBgnp@wuerfel> <3958456.qUtBLJFy2S@wuerfel> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 18 Nov 2015 14:41:36 -0600 Message-ID: <87twojghvj.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2563 Lines: 68 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Arnd Bergmann writes: > On Wednesday 18 November 2015 12:29:27 Bin Liu wrote: >> > diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig >> > index 1f2037bbeb0d..45c83baf675d 100644 >> > --- a/drivers/usb/musb/Kconfig >> > +++ b/drivers/usb/musb/Kconfig >> > @@ -159,7 +159,7 @@ config USB_TI_CPPI_DMA >> > >> > config USB_TI_CPPI41_DMA >> > bool 'TI CPPI 4.1 (AM335x)' >> > - depends on ARCH_OMAP >> > + depends on ARCH_OMAP && DMADEVICES >> > select TI_CPPI41 >>=20 >> I am not sure what the generic policy is, but instead of hiding >> USB_TI_CPPI41_DMA if DMADEVICES is disabled, I'd like to enable >> DMADEVICES if USB_TI_CPPI41_DMA is enabled, from user experience >> perspective. > > General policy is that you should not 'select' a symbol that is > also user-visible, as that tends to cause dependency loops and > other problems when something is enabled without the user being > aware of that. > > Ideally we should remove the 'select TI_CPPI41' here as well, but > what we could do instead is to make that a silent symbol and remove > the prompt so it always gets enabled implicitly when USB_TI_CPPI41_DMA > and DMADEVICES are both enabled. that should be perfect now that Tony L fixed this up so we can enable all MUSB DMA Engines in a single zImage. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWTOKBAAoJEIaOsuA1yqREDnUP/icd4reI/21Hm0gnBtYKeNay Z9ShED0iQwh1UAbqni8BlGIesgoDw47iX62q9Bjpnbdugg7i+gq+9mME85A+Sleg rH/Pm/GoH3nlpVyw+9NFAtBmqmiP7aw5d8CgWbWWjBCWM5mLeKH6BraGwhUpAxJc 4P9jTQxdVevJg63Tb28CMcXAN9WjnO//nqg270b47TgB2OuGpgAylshnwQ+w9MpZ GUx2v0D09sWAgBCHWxbWZF5P78NA/Fh/+pLJm1QjSfwqA2oIg69ZiLiyaPLXpmhB 5DiU7hR+xxpL4zdQvEs/72PnlltqCiigAh70DuFtfO8fs7b30m12E7OBJQzdUPCo 4cATTg9fy9qd7mUWCEJWDc43OTaRwMb2MEsuKQ6BXWp1pv9U8WeC/GsXx/XTMST+ 5Ffp7Dd/9kBhLvczr3AS5+ZG09eTX8RIsM17nWTMSImhL9cvKG2cxkC3Hbm2qX+T sxXuLT85yeGf9OM5BXlTY6edEIkkCWh+aoy55NxOOAl93drkstGr4XHauGd4Rv+G SyrAp3qMecFcrCCMbNHHcnfqjMaL081BsLLfRlmyPR12u3KmH2VTgMPnlkCUeRGW QtlqEZFkuxuahl+fmqQl2rafDUufmRhVo8XYGHeb6BcKtLYcYi7nwSwia3NlpMoO 46Xfw0o/RMAoMdpm32sy =TTPi -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/