Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933307AbbKRVGT (ORCPT ); Wed, 18 Nov 2015 16:06:19 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:34663 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756951AbbKRVGS (ORCPT ); Wed, 18 Nov 2015 16:06:18 -0500 Date: Wed, 18 Nov 2015 21:06:16 +0000 From: Al Viro To: Rajat Jain Cc: linux-fsdevel@vger.kernel.org, Davide Libenzi , "linux-kernel@vger.kernel.org" Subject: Re: Anonymous inode cleanup? Message-ID: <20151118210615.GE22011@ZenIV.linux.org.uk> References: <20151113063103.GO22011@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 691 Lines: 17 On Wed, Nov 18, 2015 at 12:28:38PM -0800, Rajat Jain wrote: > > _If_ you are returning them via a sucky API, the right sequence is > > reserve the descriptor(s) > > set the file(s) up > > fill whatever structure you'll be using to report descriptors to > > userland and copy it to userland memory > > If this step fails, what is the cleanup needed for "set the files up" > anon_inode_getfile() step? is it fput()? Yes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/