Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933362AbbKRVYa (ORCPT ); Wed, 18 Nov 2015 16:24:30 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:34710 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757190AbbKRVY3 (ORCPT ); Wed, 18 Nov 2015 16:24:29 -0500 Date: Wed, 18 Nov 2015 21:24:27 +0000 From: Al Viro To: Rajat Jain Cc: linux-fsdevel@vger.kernel.org, Davide Libenzi , "linux-kernel@vger.kernel.org" Subject: Re: Anonymous inode cleanup? Message-ID: <20151118212427.GF22011@ZenIV.linux.org.uk> References: <20151113063103.GO22011@ZenIV.linux.org.uk> <20151118210615.GE22011@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 647 Lines: 20 On Wed, Nov 18, 2015 at 01:10:10PM -0800, Rajat Jain wrote: > I see reference taken for the path and module in anon_inode_getfile() > > Don't I need to drop that, or would fput() do it for me? > > path_put(&path); dput(dentry); mntput(mnt); in the very end of __fput() > module_put(fops->owner); fops_put(file->f_op); slightly earlier in the same function. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/