Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757205AbbKRVZL (ORCPT ); Wed, 18 Nov 2015 16:25:11 -0500 Received: from mail-oi0-f51.google.com ([209.85.218.51]:32893 "EHLO mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756983AbbKRVZJ (ORCPT ); Wed, 18 Nov 2015 16:25:09 -0500 MIME-Version: 1.0 Reply-To: rajatxjain@gmail.com In-Reply-To: <20151118212427.GF22011@ZenIV.linux.org.uk> References: <20151113063103.GO22011@ZenIV.linux.org.uk> <20151118210615.GE22011@ZenIV.linux.org.uk> <20151118212427.GF22011@ZenIV.linux.org.uk> Date: Wed, 18 Nov 2015 13:25:08 -0800 Message-ID: Subject: Re: Anonymous inode cleanup? From: Rajat Jain To: Al Viro Cc: linux-fsdevel@vger.kernel.org, Davide Libenzi , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 755 Lines: 23 Thanks a lot! On Wed, Nov 18, 2015 at 1:24 PM, Al Viro wrote: > On Wed, Nov 18, 2015 at 01:10:10PM -0800, Rajat Jain wrote: >> I see reference taken for the path and module in anon_inode_getfile() >> >> Don't I need to drop that, or would fput() do it for me? >> >> path_put(&path); > > dput(dentry); > mntput(mnt); > in the very end of __fput() > >> module_put(fops->owner); > > fops_put(file->f_op); > slightly earlier in the same function. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/