MIME-Version: 1.0
In-Reply-To: <564D088E.7060409@android.com>
References: <1447886901-26098-1-git-send-email-dcashman@android.com>
	<1447886901-26098-2-git-send-email-dcashman@android.com>
	<CAGXu5jL7GXKqj1UTpwEwtZ_kKpeorA0fz84Pq=15kdZ3vGytQA@mail.gmail.com>
	<564D088E.7060409@android.com>
Date: Wed, 18 Nov 2015 15:26:33 -0800
Message-ID: <CAGXu5j+7ShmxMmAG-DFrtL4PpXg8Nboh53ZFVZmcYzBg2kEVFw@mail.gmail.com>
Subject: Re: [PATCH 1/4] mm: mmap: Add new /proc tunable for mmap_base ASLR.
From: Kees Cook <keescook@chromium.org>
To: Daniel Cashman <dcashman@android.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Russell King - ARM Linux <linux@arm.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        Jonathan Corbet <corbet@lwn.net>, Don Zickus <dzickus@redhat.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Heinrich Schuchardt <xypron.glpk@gmx.de>, jpoimboe@redhat.com,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        n-horiguchi@ah.jp.nec.com, Andrea Arcangeli <aarcange@redhat.com>,
        Mel Gorman <mgorman@suse.de>, Thomas Gleixner <tglx@linutronix.de>,
        David Rientjes <rientjes@google.com>, Linux-MM <linux-mm@kvack.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        Mark Salyzyn <salyzyn@android.com>,
        Jeffrey Vander Stoep <jeffv@google.com>,
        Nick Kralevich <nnk@google.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, "H. Peter Anvin" <hpa@zytor.com>,
        "x86@kernel.org" <x86@kernel.org>, Hector Marco <hecmargi@upv.es>,
        Borislav Petkov <bp@suse.de>, Daniel Cashman <dcashman@google.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 693
Lines: 19

On Wed, Nov 18, 2015 at 3:23 PM, Daniel Cashman <dcashman@android.com> wrote:
>> I think the min/max values should be const, since they're determined
>> at build time and should never change.
>
> Ok. Also, I just submitted the patch-set again with [PATCH v3] instead
> of [PATCH] so I'd prefer discussion there; sorry for the mistake.

Oops, yeah, just saw that come in after I already sent my comments. :P

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/