Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756600AbbKSAEN (ORCPT ); Wed, 18 Nov 2015 19:04:13 -0500 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:40602 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150AbbKSAEK (ORCPT ); Wed, 18 Nov 2015 19:04:10 -0500 X-IronPort-AV: E=Sophos;i="5.20,315,1444719600"; d="scan'208";a="80783694" Subject: Re: [PATCH 3/3] ARM64: dts: enable clock support for Broadcom NS2 To: Jon Mason , Florian Fainelli , Hauke Mehrtens , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , Russell King References: <1447888430-4451-1-git-send-email-jonmason@broadcom.com> <1447888430-4451-4-git-send-email-jonmason@broadcom.com> CC: , , , From: Ray Jui Message-ID: <564D11C0.409@broadcom.com> Date: Wed, 18 Nov 2015 16:03:12 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447888430-4451-4-git-send-email-jonmason@broadcom.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3821 Lines: 133 On 11/18/2015 3:13 PM, Jon Mason wrote: > Add device tree entries for clock support for Broadcom Northstar 2 SoC > > Signed-off-by: Jon Mason > --- > arch/arm64/boot/dts/broadcom/ns2.dtsi | 80 ++++++++++++++++++++++++++++++++++- > 1 file changed, 79 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/broadcom/ns2.dtsi b/arch/arm64/boot/dts/broadcom/ns2.dtsi > index 9610822..a510d3a 100644 > --- a/arch/arm64/boot/dts/broadcom/ns2.dtsi > +++ b/arch/arm64/boot/dts/broadcom/ns2.dtsi > @@ -31,6 +31,7 @@ > */ > > #include > +#include > > /memreserve/ 0x84b00000 0x00000008; > > @@ -109,6 +110,33 @@ > <&A57_3>; > }; > > + clocks { Is this a new convention? That is, group all clocks without a base register address in a node named "clocks", but at the same time, put all other clocks with base register address under a bus node. > + #address-cells = <1>; > + #size-cells = <1>; > + > + osc: oscillator { > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <25000000>; > + }; > + > + iprocmed: iprocmed { > + #clock-cells = <0>; > + compatible = "fixed-factor-clock"; > + clocks = <&genpll_scr BCM_NS2_GENPLL_SCR_SCR_CLK>; > + clock-div = <2>; > + clock-mult = <1>; > + }; > + > + iprocslow: iprocslow { > + #clock-cells = <0>; > + compatible = "fixed-factor-clock"; > + clocks = <&genpll_scr BCM_NS2_GENPLL_SCR_SCR_CLK>; > + clock-div = <4>; > + clock-mult = <1>; > + }; > + }; > + > soc: soc { > compatible = "simple-bus"; > #address-cells = <1>; > @@ -156,6 +184,56 @@ > mmu-masters; > }; > > + lcpll_ddr: lcpll_ddr@6501d058 { > + #clock-cells = <1>; > + compatible = "brcm,ns2-lcpll-ddr"; > + reg = <0x6501d058 0x20>, > + <0x6501c020 0x4>, > + <0x6501d04c 0x4>; > + clocks = <&osc>; > + clock-output-names = "lcpll_ddr", "pcie_sata_usb", > + "ddr", "ddr_ch2_unused", > + "ddr_ch3_unused", "ddr_ch4_unused", > + "ddr_ch5_unused"; > + }; > + > + lcpll_ports: lcpll_ports@6501d078 { > + #clock-cells = <1>; > + compatible = "brcm,ns2-lcpll-ports"; > + reg = <0x6501d078 0x20>, > + <0x6501c020 0x4>, > + <0x6501d054 0x4>; > + clocks = <&osc>; > + clock-output-names = "lcpll_ports", "wan", "rgmii", > + "ports_ch2_unused", > + "ports_ch3_unused", > + "ports_ch4_unused", > + "ports_ch5_unused"; > + }; > + > + genpll_scr: genpll_scr@6501d098 { > + #clock-cells = <1>; > + compatible = "brcm,ns2-genpll-scr"; > + reg = <0x6501d098 0x32>, > + <0x6501c020 0x4>, > + <0x6501d044 0x4>; > + clocks = <&osc>; > + clock-output-names = "genpll_scr", "scr", "fs", > + "audio_ref", "scr_ch3_unused", > + "scr_ch4_unused", "scr_ch5_unused"; > + }; > + > + genpll_sw: genpll_sw@6501d0c4 { > + #clock-cells = <1>; > + compatible = "brcm,ns2-genpll-sw"; > + reg = <0x6501d0c4 0x32>, > + <0x6501c020 0x4>, > + <0x6501d044 0x4>; > + clocks = <&osc>; > + clock-output-names = "genpll_sw", "rpe", "250", "nic", > + "chimp", "port", "sdio"; > + }; > + > crmu: crmu@65024000 { > compatible = "syscon"; > reg = <0x65024000 0x100>; > @@ -204,7 +282,7 @@ > interrupts = ; > reg-shift = <2>; > reg-io-width = <4>; > - clock-frequency = <23961600>; > + clocks = <&osc>; > status = "disabled"; > }; > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/