Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757219AbbKSAIx (ORCPT ); Wed, 18 Nov 2015 19:08:53 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:36326 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150AbbKSAIv (ORCPT ); Wed, 18 Nov 2015 19:08:51 -0500 Message-ID: <564D12D7.7090407@gmail.com> Date: Wed, 18 Nov 2015 16:07:51 -0800 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Ray Jui , Jon Mason , Florian Fainelli , Hauke Mehrtens , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King CC: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH 3/3] ARM64: dts: enable clock support for Broadcom NS2 References: <1447888430-4451-1-git-send-email-jonmason@broadcom.com> <1447888430-4451-4-git-send-email-jonmason@broadcom.com> <564D11C0.409@broadcom.com> In-Reply-To: <564D11C0.409@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1538 Lines: 46 On 18/11/15 16:03, Ray Jui wrote: > > > On 11/18/2015 3:13 PM, Jon Mason wrote: >> Add device tree entries for clock support for Broadcom Northstar 2 SoC >> >> Signed-off-by: Jon Mason >> --- >> arch/arm64/boot/dts/broadcom/ns2.dtsi | 80 >> ++++++++++++++++++++++++++++++++++- >> 1 file changed, 79 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/broadcom/ns2.dtsi >> b/arch/arm64/boot/dts/broadcom/ns2.dtsi >> index 9610822..a510d3a 100644 >> --- a/arch/arm64/boot/dts/broadcom/ns2.dtsi >> +++ b/arch/arm64/boot/dts/broadcom/ns2.dtsi >> @@ -31,6 +31,7 @@ >> */ >> >> #include >> +#include >> >> /memreserve/ 0x84b00000 0x00000008; >> >> @@ -109,6 +110,33 @@ >> <&A57_3>; >> }; >> >> + clocks { > > Is this a new convention? That is, group all clocks without a base > register address in a node named "clocks", but at the same time, put all > other clocks with base register address under a bus node. I do not think that is new, lots of platforms do that. The clock providers/controllers would typically be in the 'bus' nodes because it has a register interface, while the synthetic clocks would be under 'clocks'. -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/