Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757386AbbKSAKA (ORCPT ); Wed, 18 Nov 2015 19:10:00 -0500 Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:20416 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150AbbKSAJ7 (ORCPT ); Wed, 18 Nov 2015 19:09:59 -0500 X-IronPort-AV: E=Sophos;i="5.20,315,1444719600"; d="scan'208";a="81028236" Subject: Re: [PATCH 3/3] ARM64: dts: enable clock support for Broadcom NS2 To: Florian Fainelli , Jon Mason , Hauke Mehrtens , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , Russell King References: <1447888430-4451-1-git-send-email-jonmason@broadcom.com> <1447888430-4451-4-git-send-email-jonmason@broadcom.com> <564D11C0.409@broadcom.com> <564D12D7.7090407@gmail.com> CC: , , , From: Ray Jui Message-ID: <564D134E.8070205@broadcom.com> Date: Wed, 18 Nov 2015 16:09:50 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <564D12D7.7090407@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1670 Lines: 52 On 11/18/2015 4:07 PM, Florian Fainelli wrote: > On 18/11/15 16:03, Ray Jui wrote: >> >> >> On 11/18/2015 3:13 PM, Jon Mason wrote: >>> Add device tree entries for clock support for Broadcom Northstar 2 SoC >>> >>> Signed-off-by: Jon Mason >>> --- >>> arch/arm64/boot/dts/broadcom/ns2.dtsi | 80 >>> ++++++++++++++++++++++++++++++++++- >>> 1 file changed, 79 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/broadcom/ns2.dtsi >>> b/arch/arm64/boot/dts/broadcom/ns2.dtsi >>> index 9610822..a510d3a 100644 >>> --- a/arch/arm64/boot/dts/broadcom/ns2.dtsi >>> +++ b/arch/arm64/boot/dts/broadcom/ns2.dtsi >>> @@ -31,6 +31,7 @@ >>> */ >>> >>> #include >>> +#include >>> >>> /memreserve/ 0x84b00000 0x00000008; >>> >>> @@ -109,6 +110,33 @@ >>> <&A57_3>; >>> }; >>> >>> + clocks { >> >> Is this a new convention? That is, group all clocks without a base >> register address in a node named "clocks", but at the same time, put all >> other clocks with base register address under a bus node. > > I do not think that is new, lots of platforms do that. The clock > providers/controllers would typically be in the 'bus' nodes because it > has a register interface, while the synthetic clocks would be under > 'clocks'. > Okay that's very good to know. Thanks! Ray -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/