Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932976AbbKSATl (ORCPT ); Wed, 18 Nov 2015 19:19:41 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:34144 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756091AbbKSATj (ORCPT ); Wed, 18 Nov 2015 19:19:39 -0500 Date: Thu, 19 Nov 2015 09:20:38 +0900 From: Sergey Senozhatsky To: John Johansen Cc: Sergey Senozhatsky , "Serge E . Hallyn" , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 3/3] security/apparmor: do not define list_entry_next Message-ID: <20151119002038.GA537@swordfish> References: <1447848881-8202-1-git-send-email-sergey.senozhatsky@gmail.com> <564CC12A.2000505@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <564CC12A.2000505@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2729 Lines: 83 On (11/18/15 10:19), John Johansen wrote: > On 11/18/2015 04:14 AM, Sergey Senozhatsky wrote: > > Cosmetic. > > > > Do not define list_entry_next() and use list_next_entry() > > from list.h. > > > > two days to late, > > Geliang Tang already submitted the same patch in > [PATCH 3/3] apparmor: use list_next_entry instead of list_entry_next > Oh, wow. sorry for the noise. thanks. -ss > and I've pulled it into my tree > > still thank you for your work, it is appreciated > > > Signed-off-by: Sergey Senozhatsky > > --- > > security/apparmor/apparmorfs.c | 10 ++++------ > > 1 file changed, 4 insertions(+), 6 deletions(-) > > > > diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c > > index ad4fa49..946e8fd 100644 > > --- a/security/apparmor/apparmorfs.c > > +++ b/security/apparmor/apparmorfs.c > > @@ -21,6 +21,7 @@ > > #include > > #include > > #include > > +#include > > > > #include "include/apparmor.h" > > #include "include/apparmorfs.h" > > @@ -549,9 +550,6 @@ fail2: > > return error; > > } > > > > - > > -#define list_entry_next(pos, member) \ > > - list_entry(pos->member.next, typeof(*pos), member) > > #define list_entry_is_head(pos, head, member) (&pos->member == (head)) > > > > /** > > @@ -582,7 +580,7 @@ static struct aa_namespace *__next_namespace(struct aa_namespace *root, > > parent = ns->parent; > > while (ns != root) { > > mutex_unlock(&ns->lock); > > - next = list_entry_next(ns, base.list); > > + next = list_next_entry(ns, base.list); > > if (!list_entry_is_head(next, &parent->sub_ns, base.list)) { > > mutex_lock(&next->lock); > > return next; > > @@ -636,7 +634,7 @@ static struct aa_profile *__next_profile(struct aa_profile *p) > > parent = rcu_dereference_protected(p->parent, > > mutex_is_locked(&p->ns->lock)); > > while (parent) { > > - p = list_entry_next(p, base.list); > > + p = list_next_entry(p, base.list); > > if (!list_entry_is_head(p, &parent->base.profiles, base.list)) > > return p; > > p = parent; > > @@ -645,7 +643,7 @@ static struct aa_profile *__next_profile(struct aa_profile *p) > > } > > > > /* is next another profile in the namespace */ > > - p = list_entry_next(p, base.list); > > + p = list_next_entry(p, base.list); > > if (!list_entry_is_head(p, &ns->base.profiles, base.list)) > > return p; > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/