Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933693AbbKSCrY (ORCPT ); Wed, 18 Nov 2015 21:47:24 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:37920 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752587AbbKSCrW (ORCPT ); Wed, 18 Nov 2015 21:47:22 -0500 X-Listener-Flag: 11101 Message-ID: <1447901230.6731.3.camel@mtksdaap41> Subject: Re: [RESEND RFC/PATCH 1/8] dt-bindings: Add a binding for Mediatek Video Processor Unit From: andrew-ct chen To: Mark Rutland CC: Tiffany Lin , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , "Catalin Marinas" , Will Deacon , "Mauro Carvalho Chehab" , Matthias Brugger , Daniel Kurtz , Sascha Hauer , Hongzhou Yang , "Hans Verkuil" , Laurent Pinchart , Sakari Ailus , Geert Uytterhoeven , Mikhail Ulyanov , Fabien Dessenne , Arnd Bergmann , Darren Etheridge , Peter Griffin , "Benoit Parrot" , Eddie Huang , "Yingjoe Chen" , James Liao , Daniel Hsiao , , , , , Date: Thu, 19 Nov 2015 10:47:10 +0800 In-Reply-To: <20151117141320.GJ12586@leverpostej> References: <1447764885-23100-1-git-send-email-tiffany.lin@mediatek.com> <1447764885-23100-2-git-send-email-tiffany.lin@mediatek.com> <20151117141320.GJ12586@leverpostej> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2510 Lines: 69 On Tue, 2015-11-17 at 14:13 +0000, Mark Rutland wrote: > On Tue, Nov 17, 2015 at 08:54:38PM +0800, Tiffany Lin wrote: > > From: Andrew-CT Chen > > > > Add a DT binding documentation of Video Processor Unit for the > > MT8173 SoC from Mediatek. > > > > Signed-off-by: Andrew-CT Chen > > --- > > .../devicetree/bindings/media/mediatek-vpu.txt | 27 ++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/mediatek-vpu.txt > > > > diff --git a/Documentation/devicetree/bindings/media/mediatek-vpu.txt b/Documentation/devicetree/bindings/media/mediatek-vpu.txt > > new file mode 100644 > > index 0000000..99a4e5e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/mediatek-vpu.txt > > @@ -0,0 +1,27 @@ > > +* Mediatek Video Processor Unit > > + > > +Video Processor Unit is a HW video controller. It controls HW Codec including > > +H.264/VP8/VP9 Decode, H.264/VP8 Encode and Image Processor (scale/rotate/color convert). > > + > > +Required properties: > > + - compatible: "mediatek,mt8173-vpu" > > + - reg: Must contain an entry for each entry in reg-names. > > + - reg-names: Must include the following entries: > > + "sram": SRAM base > > + "cfg_reg": Main configuration registers base > > + - interrupts: interrupt number to the cpu. > > + - clocks : clock name from clock manager > > + - clock-names: the clocks of the VPU H/W > > You need to explicitly define the set of clock-names you expect here. > > Mark. Sorry, only one clock to enable VPU hardware. We will modify to - clocks : must contain one entry for each clock-names. - clock-names : must be "main", It is the main clock of VPU. Thanks.. > > > + - iommus : phandle and IOMMU spcifier for the IOMMU that serves the VPU. > > + > > +Example: > > + vpu: vpu@10020000 { > > + compatible = "mediatek,mt8173-vpu"; > > + reg = <0 0x10020000 0 0x30000>, > > + <0 0x10050000 0 0x100>; > > + reg-names = "sram", "cfg_reg"; > > + interrupts = ; > > + clocks = <&topckgen TOP_SCP_SEL>; > > + clock-names = "main"; > > + iommus = <&iommu M4U_PORT_VENC_RCPU>; > > + }; > > -- > > 1.7.9.5 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/