Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933731AbbKSEZH (ORCPT ); Wed, 18 Nov 2015 23:25:07 -0500 Received: from eusmtp01.atmel.com ([212.144.249.243]:40363 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756164AbbKSEZF (ORCPT ); Wed, 18 Nov 2015 23:25:05 -0500 From: "Yang, Wenyou" To: Marc Kleine-Budde , Wolfgang Grandegger CC: "linux-can@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Ferre, Nicolas" Subject: RE: [PATCH 2/2] can: m_can: Add CAN clock generated by UPLLCK support Thread-Topic: [PATCH 2/2] can: m_can: Add CAN clock generated by UPLLCK support Thread-Index: AQHRIelMauNuxpQxH0qE2gKaJO7cfZ6hDEsAgAG0HlA= Date: Thu, 19 Nov 2015 04:24:59 +0000 Message-ID: References: <1447841049-5010-1-git-send-email-wenyou.yang@atmel.com> <1447841049-5010-3-git-send-email-wenyou.yang@atmel.com> <564C518A.8000501@pengutronix.de> In-Reply-To: <564C518A.8000501@pengutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.168.5.13] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tAJ4PEpD023554 Content-Length: 3176 Lines: 95 Hi Marc, > -----Original Message----- > From: Marc Kleine-Budde [mailto:mkl@pengutronix.de] > Sent: 2015年11月18日 18:23 > To: Yang, Wenyou; Wolfgang Grandegger > Cc: linux-can@vger.kernel.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; Ferre, Nicolas > Subject: Re: [PATCH 2/2] can: m_can: Add CAN clock generated by UPLLCK > support > > On 11/18/2015 11:04 AM, Wenyou Yang wrote: > > As said SAMA5D2 datasheet, it is recommended to use the CAN clock at > > frequencies of 20, 40 or 80 MHz. To achieve these frequencies, PMC > > GCK3 must select the UPLLCK(480 MHz) as source clock and divide by 24, > > 12 or 6. In this patch the CAN clock at 20 MHz. > > > > As it is configured through DT, it doesn't affect the M_CAN without > > configuring CAN clock and its generated clock. > > > > Signed-off-by: Wenyou Yang > > NACK > > Please do this setup in your SoC code, where you setup the clock infrastructure or > have a look at Documentation/devicetree/bindings/clock/clock-bindings.txt > "Assigned clock parents and rates" Thank you for your advice. I will do this setup via DT. > > > --- > > > > drivers/net/can/m_can/m_can.c | 16 +++++++++++++++- > > 1 file changed, 15 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/can/m_can/m_can.c > > b/drivers/net/can/m_can/m_can.c index fd1caa0..2ca47db 100644 > > --- a/drivers/net/can/m_can/m_can.c > > +++ b/drivers/net/can/m_can/m_can.c > > @@ -269,6 +269,8 @@ enum m_can_mram_cfg { > > #define TX_BUF_XTD BIT(30) > > #define TX_BUF_RTR BIT(29) > > > > +#define AT91_CAN_CLK_FREQ 20000000 > > + > > /* address offset and element number for each FIFO/Buffer in the > > Message RAM */ struct mram_cfg { > > u16 off; > > @@ -1188,7 +1190,7 @@ static int m_can_plat_probe(struct platform_device > *pdev) > > struct m_can_priv *priv; > > struct resource *res; > > void __iomem *addr; > > - struct clk *hclk, *cclk; > > + struct clk *hclk, *cclk, *upll_clk; > > int irq, ret; > > > > hclk = devm_clk_get(&pdev->dev, "hclk"); @@ -1198,6 +1200,18 @@ > > static int m_can_plat_probe(struct platform_device *pdev) > > return -ENODEV; > > } > > > > + upll_clk = devm_clk_get(&pdev->dev, "upllclk"); > > + if (!IS_ERR(upll_clk)) { > > + ret = clk_set_parent(cclk, upll_clk); > > + if (!ret) { > > + ret = clk_set_rate(cclk, AT91_CAN_CLK_FREQ); > > + if (ret) { > > + dev_err(&pdev->dev, "failed to set gck\n"); > > + return -ENODEV; > > + } > > + } > > + } > > + > > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > "m_can"); > > addr = devm_ioremap_resource(&pdev->dev, res); > > irq = platform_get_irq_byname(pdev, "int0"); > > > > regards, > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Industrial Linux Solutions | Phone: +49-231-2826-924 | > Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | > Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | Best Regards, Wenyou Yang ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?