Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933915AbbKSEZ2 (ORCPT ); Wed, 18 Nov 2015 23:25:28 -0500 Received: from nasmtp01.atmel.com ([192.199.1.245]:28365 "EHLO DVREDG01.corp.atmel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933848AbbKSEZW (ORCPT ); Wed, 18 Nov 2015 23:25:22 -0500 From: "Yang, Wenyou" To: Marc Kleine-Budde , Wolfgang Grandegger CC: "linux-can@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Ferre, Nicolas" Subject: RE: [PATCH 1/2] can: m_can: Increase delay to ensure written INIT accepted Thread-Topic: [PATCH 1/2] can: m_can: Increase delay to ensure written INIT accepted Thread-Index: AQHRIelIT4BvTc1KyUGt5ZaQgjO0Bp6hDRYAgAGyU7A= Date: Thu, 19 Nov 2015 04:25:17 +0000 Message-ID: References: <1447841049-5010-1-git-send-email-wenyou.yang@atmel.com> <1447841049-5010-2-git-send-email-wenyou.yang@atmel.com> <564C5234.40708@pengutronix.de> In-Reply-To: <564C5234.40708@pengutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.168.5.13] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tAJ4PYVp023566 Content-Length: 1964 Lines: 64 Hi Marc, Thank you for prompt feedback. > -----Original Message----- > From: Marc Kleine-Budde [mailto:mkl@pengutronix.de] > Sent: 2015年11月18日 18:26 > To: Yang, Wenyou; Wolfgang Grandegger > Cc: linux-can@vger.kernel.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; Ferre, Nicolas > Subject: Re: [PATCH 1/2] can: m_can: Increase delay to ensure written INIT > accepted > > On 11/18/2015 11:04 AM, Wenyou Yang wrote: > > Increase the delay time until the value written to INIT can be read > > back to ensure that the previous value written to INIT has been > > accepted. I tested it again with different clock frequencies, it works without this patch. Maybe I made a mistake. Sorry about it. Please ignore. > > > > Signed-off-by: Wenyou Yang > > The patch looks ok, can you please add to your commit message which SoCs are > affected by this problem. > > > --- > > > > drivers/net/can/m_can/m_can.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/can/m_can/m_can.c > > b/drivers/net/can/m_can/m_can.c index ef65517..fd1caa0 100644 > > --- a/drivers/net/can/m_can/m_can.c > > +++ b/drivers/net/can/m_can/m_can.c > > @@ -320,7 +320,7 @@ static inline void m_can_config_endisable(const struct > m_can_priv *priv, > > bool enable) > > { > > u32 cccr = m_can_read(priv, M_CAN_CCCR); > > - u32 timeout = 10; > > + u32 timeout = 1000; > > u32 val = 0; > > > > if (enable) { > > > > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Industrial Linux Solutions | Phone: +49-231-2826-924 | > Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | > Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | Best Regards, Wenyou Yang ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?