Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933799AbbKSEwV (ORCPT ); Wed, 18 Nov 2015 23:52:21 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:9752 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756164AbbKSEwT (ORCPT ); Wed, 18 Nov 2015 23:52:19 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Wed, 18 Nov 2015 20:49:47 -0800 From: Alexandre Courbot To: Thierry Reding , Terje Bergstrom CC: Daniel Vetter , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, gnurou@gmail.com, Alexandre Courbot Subject: [PATCH v2] drm/tegra: fix locking of SET_TILING ioctl Date: Thu, 19 Nov 2015 13:51:38 +0900 Message-ID: <1447908698-25075-1-git-send-email-acourbot@nvidia.com> X-Mailer: git-send-email 2.6.2 X-NVConfidentiality: public MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1243 Lines: 37 Commit ef4c6270bf28 made the check of whether struct_mutex is held more verbose, and this triggers a warning when calling drm_gem_object_unreference() from tegra_gem_set_tiling() which does not acquire that lock. Use drm_gem_object_unreference_unlocked() instead to ensure locking is handled correctly. Signed-off-by: Alexandre Courbot Reviewed-by: Daniel Vetter --- v2: fix commit log according to Daniel's comments, add review tag. drivers/gpu/drm/tegra/drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c index cc48334ef164..c0ae89865958 100644 --- a/drivers/gpu/drm/tegra/drm.c +++ b/drivers/gpu/drm/tegra/drm.c @@ -683,7 +683,7 @@ static int tegra_gem_set_tiling(struct drm_device *drm, void *data, bo->tiling.mode = mode; bo->tiling.value = value; - drm_gem_object_unreference(gem); + drm_gem_object_unreference_unlocked(gem); return 0; } -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/