Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933895AbbKSEwZ (ORCPT ); Wed, 18 Nov 2015 23:52:25 -0500 Received: from mail-ig0-f169.google.com ([209.85.213.169]:37077 "EHLO mail-ig0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933809AbbKSEwW (ORCPT ); Wed, 18 Nov 2015 23:52:22 -0500 MIME-Version: 1.0 In-Reply-To: <20151117100241.GN16848@phenom.ffwll.local> References: <1447312196-11470-1-git-send-email-acourbot@nvidia.com> <20151117100241.GN16848@phenom.ffwll.local> From: Alexandre Courbot Date: Thu, 19 Nov 2015 13:52:02 +0900 Message-ID: Subject: Re: [PATCH] drm/tegra: fix locking of SET_TILING ioctl To: Alexandre Courbot , Thierry Reding , Terje Bergstrom , "linux-tegra@vger.kernel.org" , Alexandre Courbot , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 968 Lines: 24 On Tue, Nov 17, 2015 at 7:02 PM, Daniel Vetter wrote: > On Thu, Nov 12, 2015 at 04:09:56PM +0900, Alexandre Courbot wrote: >> drm_gem_object_unreference() now expects obj->dev->struct_mutex to be >> held. Use the newly-introduced drm_gem_object_unreference_unlocked() >> which handles locking for us. > > This rule has been really old, I simply made the checking more anal in > > commit ef4c6270bf2867e2f8032e9614d1a8cfc6c71663 > Author: Daniel Vetter > Date: Thu Oct 15 09:36:25 2015 +0200 > > drm/gem: Check locking in drm_gem_object_unreference > > With the above added this is: > > Reviewed-by: Daniel Vetter