Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752520AbbKSGEb (ORCPT ); Thu, 19 Nov 2015 01:04:31 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:58670 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750908AbbKSGE3 (ORCPT ); Thu, 19 Nov 2015 01:04:29 -0500 Date: Thu, 19 Nov 2015 00:04:26 -0600 From: Andy Gross To: Stephen Boyd Cc: Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, "Ivan T. Ivanov" , Bjorn Andersson Subject: Re: [PATCH] pinctrl: qcom: pmic-gpio/mpp: of_irq_count() == npins Message-ID: <20151119060426.GA22622@qualcomm.com> References: <1447808426-21834-1-git-send-email-sboyd@codeaurora.org> <1447875197-21645-1-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447875197-21645-1-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1084 Lines: 27 On Wed, Nov 18, 2015 at 11:33:17AM -0800, Stephen Boyd wrote: > The number of interrupts is always equal to the number of pins > provided by the PMIC gpio and MPP hardware blocks. Count the > number of irqs to figure out the number of pins instead of adding > more compatible strings or doing math on the reg property. This > should make the code more generic and ease the number of changes > we have to make to the driver for each new pmic revision. > > Cc: "Ivan T. Ivanov" > Cc: Bjorn Andersson > Signed-off-by: Stephen Boyd > --- This is pretty nice. Reviewed-by: Andy Gross -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/