Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758098AbbKSJQY (ORCPT ); Thu, 19 Nov 2015 04:16:24 -0500 Received: from mail-qk0-f169.google.com ([209.85.220.169]:33651 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755978AbbKSJQU (ORCPT ); Thu, 19 Nov 2015 04:16:20 -0500 MIME-Version: 1.0 In-Reply-To: <564D5552.4070806@samsung.com> References: <1447637775-9887-1-git-send-email-k.kozlowski@samsung.com> <1447637775-9887-2-git-send-email-k.kozlowski@samsung.com> <564D5552.4070806@samsung.com> Date: Thu, 19 Nov 2015 18:16:18 +0900 Message-ID: Subject: Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 From: Tomasz Figa To: Krzysztof Kozlowski Cc: Sylwester Nawrocki , Michael Turquette , Stephen Boyd , "linux-samsung-soc@vger.kernel.org" , linux-clk@vger.kernel.org, linux-kernel , Catalin Marinas , Will Deacon , Kukjin Kim , Olof Johansson , Arnd Bergmann , linux-arm-kernel , Kevin Hilman , Pankaj Dubey Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1717 Lines: 39 2015-11-19 13:51 GMT+09:00 Krzysztof Kozlowski : > On 19.11.2015 13:18, Tomasz Figa wrote: >> However, I don't think we can disable compilation of particular 64-bit >> SoCs, so maybe there isn't much sense in splitting their clock drivers >> into separate symbols? > > To me it does not really matter. Indeed as you said one cannot disable > building of one particular Exynos SoCs. > > However we could still want not build some parts of such SoCs (like > clock, pinctrl etc). I don't see much benefit for such case except when > someone would like to drastically reduce the size of kernel image (for > whatever reasons he has.). Can we really build a kernel that support selected Exynos SoC without its clock driver? Actually I don't think we even allow deselecting clock drivers currently, because they are not visible in menuconfig. Unless there is a clear goal to separate ARCH level Kconfig symbol for particular ARM64-based Exynos SoCs, I don't think it makes any sense to keep the clock-related symbols separate. > > On the other hand having separate symbols causes duplication and > obfuscates a little the Kconfig/Makefile. I like keeping things simple > so one symbol for all ARM64 Exynos clocks sounds good. > > Sylwester preferred current approach. You and Pankaj seem to prefer one > symbol-way. Hmm, I read Sylwester's post as a reply to your original message and not Pankaj's. Sylwester, could you clarify? Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/