Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934115AbbKSLbK (ORCPT ); Thu, 19 Nov 2015 06:31:10 -0500 Received: from mail-yk0-f182.google.com ([209.85.160.182]:36818 "EHLO mail-yk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933235AbbKSLbH (ORCPT ); Thu, 19 Nov 2015 06:31:07 -0500 MIME-Version: 1.0 In-Reply-To: <1447327631-26947-1-git-send-email-yalin.wang2010@gmail.com> References: <1447327631-26947-1-git-send-email-yalin.wang2010@gmail.com> Date: Thu, 19 Nov 2015 12:31:06 +0100 Message-ID: Subject: Re: [PATCH V2] mmc: change to use kmalloc From: Ulf Hansson To: yalin wang Cc: Adrian Hunter , Andrew Morton , Tobias Klauser , "JBottomley@Odin.com" , Ben Hutchings , "Dong, Chuanxiao" , Shawn Lin , =?UTF-8?B?SnVzdGluIFdhbmcgKOeOi+S4gSk=?= , linux-mmc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1578 Lines: 46 On 12 November 2015 at 12:27, yalin wang wrote: > Use kmalloc instead of kzalloc, zero the memory is not needed. > > Signed-off-by: yalin wang Thanks, applied for next! I took liberty to update the change log and the commit message header to make it more descriptive. Kind regards Uffe > --- > drivers/mmc/card/block.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c > index c742cfd..c3fd4c8 100644 > --- a/drivers/mmc/card/block.c > +++ b/drivers/mmc/card/block.c > @@ -345,7 +345,7 @@ static struct mmc_blk_ioc_data *mmc_blk_ioctl_copy_from_user( > struct mmc_blk_ioc_data *idata; > int err; > > - idata = kzalloc(sizeof(*idata), GFP_KERNEL); > + idata = kmalloc(sizeof(*idata), GFP_KERNEL); > if (!idata) { > err = -ENOMEM; > goto out; > @@ -365,7 +365,7 @@ static struct mmc_blk_ioc_data *mmc_blk_ioctl_copy_from_user( > if (!idata->buf_bytes) > return idata; > > - idata->buf = kzalloc(idata->buf_bytes, GFP_KERNEL); > + idata->buf = kmalloc(idata->buf_bytes, GFP_KERNEL); > if (!idata->buf) { > err = -ENOMEM; > goto idata_err; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/