Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758190AbbKSLeD (ORCPT ); Thu, 19 Nov 2015 06:34:03 -0500 Received: from mail-yk0-f170.google.com ([209.85.160.170]:33550 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751165AbbKSLeA (ORCPT ); Thu, 19 Nov 2015 06:34:00 -0500 MIME-Version: 1.0 In-Reply-To: <1446550651-7977-1-git-send-email-peter.ujfalusi@ti.com> References: <1446550651-7977-1-git-send-email-peter.ujfalusi@ti.com> Date: Thu, 19 Nov 2015 12:33:59 +0100 Message-ID: Subject: Re: [PATCH] mmc: omap_hsmmc: No need to check DMA channel validity at module remove From: Ulf Hansson To: Peter Ujfalusi Cc: Tony Lindgren , Kishon , linux-mmc , linux-omap , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1413 Lines: 41 On 3 November 2015 at 12:37, Peter Ujfalusi wrote: > The driver will not probe without valid DMA channels so no need to check > if they are valid when the module is removed. > > Signed-off-by: Peter Ujfalusi > CC: Ulf Hansson Thanks, applied for next! Kind regards Uffe > --- > drivers/mmc/host/omap_hsmmc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index f70e52b05648..712c74fd0401 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -2262,10 +2262,8 @@ static int omap_hsmmc_remove(struct platform_device *pdev) > pm_runtime_get_sync(host->dev); > mmc_remove_host(host->mmc); > > - if (host->tx_chan) > - dma_release_channel(host->tx_chan); > - if (host->rx_chan) > - dma_release_channel(host->rx_chan); > + dma_release_channel(host->tx_chan); > + dma_release_channel(host->rx_chan); > > pm_runtime_put_sync(host->dev); > pm_runtime_disable(host->dev); > -- > 2.6.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/