Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932127AbbKSNVX (ORCPT ); Thu, 19 Nov 2015 08:21:23 -0500 Received: from mx2.suse.de ([195.135.220.15]:52727 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756599AbbKSNVV (ORCPT ); Thu, 19 Nov 2015 08:21:21 -0500 From: Andreas Schwab To: Arnd Bergmann Cc: Yury Norov , catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pinskia@gmail.com, ddaney.cavm@gmail.com, jan.dakinevich@gmail.com, Prasun.Kapoor@caviumnetworks.com, christoph.muellner@theobroma-systems.com, philipp.tomsich@theobroma-systems.com, broonie@kernel.org, andrey.konovalov@linaro.org, Nathan_Lynch@mentor.com, agraf@suse.de, bamvor.zhangjian@huawei.com, klimov.linux@gmail.com, joseph@codesourcery.com Subject: Re: [PATCH v6 14/19] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it References: <1447795019-30176-1-git-send-email-ynorov@caviumnetworks.com> <1447795019-30176-15-git-send-email-ynorov@caviumnetworks.com> <3754277.KmO9Nk3XLD@wuerfel> X-Yow: I'm in DISGUISE as a BAGGAGE CHECKER....I can watch the house, if it's ORANGE... Date: Thu, 19 Nov 2015 14:21:16 +0100 In-Reply-To: <3754277.KmO9Nk3XLD@wuerfel> (Arnd Bergmann's message of "Tue, 17 Nov 2015 22:57:52 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 746 Lines: 21 Arnd Bergmann writes: > On Wednesday 18 November 2015 00:16:54 Yury Norov wrote: >> +#define sys_lseek sys_llseek > > This seems pointless, as there is no sys_lseek I think it should be the other way round. Why would you want to use llseek if you can pass loff_t in a single register? Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/