Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934146AbbKSNu3 (ORCPT ); Thu, 19 Nov 2015 08:50:29 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37237 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932882AbbKSNu1 (ORCPT ); Thu, 19 Nov 2015 08:50:27 -0500 Date: Thu, 19 Nov 2015 14:50:24 +0100 From: Michal Hocko To: Johannes Weiner Cc: David Miller , Andrew Morton , Vladimir Davydov , Tejun Heo , netdev@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 13/14] mm: memcontrol: account socket memory in unified hierarchy memory controller Message-ID: <20151119135023.GH8494@dhcp22.suse.cz> References: <1447371693-25143-1-git-send-email-hannes@cmpxchg.org> <1447371693-25143-14-git-send-email-hannes@cmpxchg.org> <20151116155923.GH14116@dhcp22.suse.cz> <20151116181810.GB32544@cmpxchg.org> <20151118162256.GK19145@dhcp22.suse.cz> <20151118214822.GA1365@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151118214822.GA1365@cmpxchg.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1648 Lines: 42 On Wed 18-11-15 16:48:22, Johannes Weiner wrote: [...] > So I ran perf record -g -a netperf -t TCP_STREAM multiple times inside > a memory-controlled cgroup, but mostly mem_cgroup_charge_skmem() does > not show up in the profile at all. Once it was there with 0.00%. OK, this sounds very good! This means that most workloads which are not focusing solely on the network traffic shouldn't even notice. I can imagine that workloads with high throughput demands would notice but I would also expect them to disable the feature. Could you add this information to the changelog, please? > I ran another test that downloads the latest kernel image from > kernel.org at 13MB/s (on my i5 laptop) and it looks like this: > > 0.02% 0.01% irq/44-iwlwifi [kernel.kallsyms] [k] mem_cgroup_charge_skmem > | > ---mem_cgroup_charge_skmem > __sk_mem_schedule > tcp_try_rmem_schedule > tcp_data_queue > tcp_rcv_established > tcp_v4_do_rcv > tcp_v4_rcv > ip_local_deliver > ip_rcv > __netif_receive_skb_core > __netif_receive_skb > netif_receive_skb_internal > napi_gro_complete > > The runs vary too much for this to be measurable in elapsed time. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/