Date: Thu, 19 Nov 2015 14:57:30 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>, Mans Rullgard <mans@mansr.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Nicolas Pitre <nico@linaro.org>, Tony Lindgren <tony@atomide.com>,
        Sebastian Frias <sebastian_frias@sigmadesigns.com>
Subject: Re: [PATCH] clocksource: Store reg field within struct clocksource
In-Reply-To: <564DC006.8000406@sigmadesigns.com>
Message-ID: <alpine.DEB.2.11.1511191457160.3898@nanos>
References: <564C8086.80804@sigmadesigns.com> <20151118172114.GS8644@n2100.arm.linux.org.uk> <alpine.DEB.2.11.1511191130480.3898@nanos> <20151119103645.GV8644@n2100.arm.linux.org.uk> <alpine.DEB.2.11.1511191137320.3898@nanos> <20151119110842.GX8644@n2100.arm.linux.org.uk>
 <alpine.DEB.2.11.1511191209000.3898@nanos> <564DC006.8000406@sigmadesigns.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 780
Lines: 19

On Thu, 19 Nov 2015, Marc Gonzalez wrote:
> On 19/11/2015 12:14, Thomas Gleixner wrote:
> 
> > So yes, the alignment of the clocksource struct is not longer
> > relevant. The case where we access clocksource->max_cycles is when
> > CONFIG_DEBUG_TIMEKEEPING is enabled, which imposes worse performance
> > problems to timekeeping than the extra cacheline.
> > 
> > So the simple solution for this issue is indeed the one liner below.
> 
> It would make sense to also remove the comment emphasizing the
> alignment requirement.

Indeed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/