Date: Thu, 19 Nov 2015 07:35:23 -0800
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Javi Merino <javi.merino@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        John Stultz <john.stultz@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Len Brown <len.brown@intel.com>,
        Rafael Wysocki <rafael.j.wysocki@intel.com>,
        Eduardo Valentin <edubezval@gmail.com>, Paul Turner <pjt@google.com>,
        Steven Rostedt <rostedt@goodmis.org>, jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH 4/4] sched: add trace event for idle injection
Message-ID: <20151119073523.656c2fcb@icelake>
In-Reply-To: <20151119143934.GB9512@e104805>
References: <1447444387-23525-1-git-send-email-jacob.jun.pan@linux.intel.com>
	<1447444387-23525-5-git-send-email-jacob.jun.pan@linux.intel.com>
	<20151119143934.GB9512@e104805>
Organization: OTC
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 705
Lines: 21

On Thu, 19 Nov 2015 14:39:35 +0000
Javi Merino <javi.merino@arm.com> wrote:

> > +  
> 
> One minor nit: can you use key=value (i.e. "throttled=%d") instead for
> consistency with the rest of this file?
> 
will do. 
> Other than that, I know that Peter suggested an enum for the action,
> but wouldn't it be better to create an EVENT_CLASS and subclass the
> three actions from it?  Something like:
I agree, it will be more readable in the trace.


thanks you
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/