From: "Tirdea, Irina" <irina.tirdea@intel.com>
To: Bastien Nocera <hadess@hadess.net>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Aleksei Mamlin <mamlinav@gmail.com>,
        "Karsten Merker" <merker@debian.org>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
CC: Mark Rutland <mark.rutland@arm.com>, Rob Herring <robh+dt@kernel.org>,
        "Purdila, Octavian" <octavian.purdila@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v11 2/8] Input: goodix - reset device at init
Thread-Topic: [PATCH v11 2/8] Input: goodix - reset device at init
Thread-Index: AQHRIt6FZYgAc7VpCUWlgeHyG0KvmZ6jd89w
Date: Thu, 19 Nov 2015 15:36:12 +0000
Deferred-Delivery: Thu, 19 Nov 2015 15:35:00 +0000
Message-ID: <1F3AC3675D538145B1661F571FE1805F2F11F7FD@irsmsx105.ger.corp.intel.com>
References: <1447936001-21420-1-git-send-email-irina.tirdea@intel.com>
	 <1447936001-21420-3-git-send-email-irina.tirdea@intel.com>
 <1447946703.24088.73.camel@hadess.net>
In-Reply-To: <1447946703.24088.73.camel@hadess.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1656
Lines: 39


> -----Original Message-----
> From: Bastien Nocera [mailto:hadess@hadess.net]
> Sent: 19 November, 2015 17:25
> To: Tirdea, Irina; Dmitry Torokhov; Aleksei Mamlin; Karsten Merker; linux-input@vger.kernel.org
> Cc: Mark Rutland; Rob Herring; Purdila, Octavian; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [PATCH v11 2/8] Input: goodix - reset device at init
> 
> On Thu, 2015-11-19 at 14:26 +0200, Irina Tirdea wrote:
> > After power on, it is recommended that the driver resets the device.
> > The reset procedure timing is described in the datasheet and is used
> > at device init (before writing device configuration) and
> > for power management. It is a sequence of setting the interrupt
> > and reset pins high/low at specific timing intervals. This procedure
> > also includes setting the slave address to the one specified in the
> > ACPI/device tree.
> 
> This fails on a 4.3 kernel with an ACPI device (WinBook TW100):
> Goodix-TS: probe of i2c-GDIX1001:00 failed with error -16
> 
> Can you please document which upstream commit is necessary to make this
> behave properly?
> 

You need the patch that fixes the GPIO API [1] so that
devm_gpiod_get_optional works properly (I mentioned that in the cover
letter). This patch just got merged in the gpio tree, so it will take a
while until it will be merged in the main kernel tree or input tree. 

Thanks,
Irina

 [1] https://lkml.org/lkml/2015/11/11/465

> I'll test again with a newer kernel.
> 
> Cheers
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?