Message-ID: <564DF576.9010807@mleia.com>
Date: Thu, 19 Nov 2015 18:14:46 +0200
From: Vladimir Zapolskiy <vz@mleia.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Icedove/31.6.0
MIME-Version: 1.0
To: "Andrew F. Davis" <afd@ti.com>, Cory Tusar <cory.tusar@pid1solutions.com>,
        robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
        ijc+devicetree@hellion.org.uk, galak@codeaurora.org, agust@denx.de,
        gregkh@linuxfoundation.org
CC: jic23@kernel.org, broonie@kernel.org, andrew@lunn.ch, Chris.Healy@zii.aero,
        Keith.Vennel@zii.aero, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] misc: eeprom_93xx46: Implement eeprom_93xx46 DT
 bindings.
References: <1447903781-3910-1-git-send-email-cory.tusar@pid1solutions.com> <1447903781-3910-4-git-send-email-cory.tusar@pid1solutions.com> <564D632D.8020107@mleia.com> <564DD5E7.6080700@ti.com>
In-Reply-To: <564DD5E7.6080700@ti.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1577
Lines: 56

Hi Andrew,

On 19.11.2015 16:00, Andrew F. Davis wrote:
> On 11/18/2015 11:50 PM, Vladimir Zapolskiy wrote:
>> Hi Cory,
>>
>> On 19.11.2015 05:29, Cory Tusar wrote:
>>> This commit implements bindings in the eeprom_93xx46 driver allowing
>>> device word size and read-only attributes to be specified via
>>> devicetree.
>>>
>>> Signed-off-by: Cory Tusar <cory.tusar@pid1solutions.com>
>>> ---

[snip]

>>> +
>>> +#else
>>> +static inline int eeprom_93xx46_probe_dt(struct spi_device *spi)
>>> +{
>>> +	return 0;
>>> +}
>>> +#endif
>>> +
>>
>> I actually don't see a point to have #ifdef CONFIG_OF here.
>>
> 
> Usually to avoid a lot of dead code and data when OF is not enabled.
> 

This is a premature optimization.


Also please see Documentation/CodingStyle, Chapter 20: Conditional
Compilation:

	Wherever possible, don't use preprocessor conditionals
	(#if, #ifdef) in .c files; doing so makes code harder to read
	and logic harder to follow.  Instead, use such conditionals in
	a header file defining functions for use in those .c files,
	providing no-op stub versions in the #else case, and then call
	those functions unconditionally from .c files.  The compiler
	will avoid generating any code for the stub calls, producing
	identical results, but the logic will remain easy to follow.

etc.

--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/