Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934386AbbKSQac (ORCPT ); Thu, 19 Nov 2015 11:30:32 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:50871 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934176AbbKSQab convert rfc822-to-8bit (ORCPT ); Thu, 19 Nov 2015 11:30:31 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Guenter Roeck Cc: Wim Van Sebroeck , linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH v2 2/2] watchdog: add support for Sigma Designs SMP86xx/SMP87xx References: <1447869343-25168-1-git-send-email-mans@mansr.com> <1447869343-25168-2-git-send-email-mans@mansr.com> <564DF807.3040608@roeck-us.net> Date: Thu, 19 Nov 2015 16:30:22 +0000 In-Reply-To: <564DF807.3040608@roeck-us.net> (Guenter Roeck's message of "Thu, 19 Nov 2015 08:25:43 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 886 Lines: 25 Guenter Roeck writes: >> + writel(WD_CONFIG_XTAL_IN, dev->base + WD_CONFIG); > > What happens if the DISABLE bit was previously set (assuming > that DISABLE means that the watchdog is disabled) ? > > Concern I guess would be the combination of DISABLE being set > and WD_COUNTER at a value != 0 (say, 1). That might effectively > auto-enable the watchdog or even reset the system. There's no sane reason why it would be in that state, but then again firmware authors are not sane. How about checking the DISABLE bit, and if it's set turn off the counter, otherwise leave it running? -- M?ns Rullg?rd mans@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/