Subject: Re: [PATCH 3/5] mm, page_owner: copy page owner info during migration
To: Hugh Dickins <hughd@google.com>
References: <1446649261-27122-1-git-send-email-vbabka@suse.cz>
 <1446649261-27122-4-git-send-email-vbabka@suse.cz>
 <alpine.LSU.2.11.1511081318110.12914@eggly.anvils>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>, Minchan Kim <minchan@kernel.org>,
        Sasha Levin <sasha.levin@oracle.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Mel Gorman <mgorman@suse.de>
From: Vlastimil Babka <vbabka@suse.cz>
Message-ID: <564DFC5C.2090103@suse.cz>
Date: Thu, 19 Nov 2015 17:44:12 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <alpine.LSU.2.11.1511081318110.12914@eggly.anvils>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1273
Lines: 33

On 11/08/2015 10:29 PM, Hugh Dickins wrote:
>
> Would it be possible to move that line into migrate_page_copy()?
>
> I don't think it's wrong where you placed it, but that block is really
> about resetting the old page ready for freeing, and I'd prefer to keep
> all the transference of properties from old to new in migrate_page_copy()
> if we can.

OK, makes sense, will do in v2.

> But check how that behaves in the migrate_misplaced_transhuge_page()
> case: I haven't studied long enough, but I think you may have been missing
> to copy_page_owner in that case;

You're right, I missed that path :/

> but beware of its "fail_putback", which
> for some things nastily entails undoing what's already been done.

Yeah, I think I don't need to reset page owner info in the fail_putback 
path, for the same reason I don't reset it from the old page when 
migration is successful. The page is going to be freed anyway, and if it 
somehow hits a bug before that, we will still have something to print 
(after patch 5).

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/