From: Hartley Sweeten <HartleyS@visionengravers.com>
To: Ian Abbott <abbotti@mev.co.uk>,
        "driverdev-devel@linuxdriverproject.org" 
	<driverdev-devel@linuxdriverproject.org>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 0/8] staging: comedi: some comedi_write() changes
Thread-Topic: [PATCH 0/8] staging: comedi: some comedi_write() changes
Thread-Index: AQHRIipNACbvPmUncUCc75edtDtiN56jmN5w
Date: Thu, 19 Nov 2015 17:23:51 +0000
Message-ID: <BN3PR0101MB1057F763909B1F74C27DE5DDD01B0@BN3PR0101MB1057.prod.exchangelabs.com>
References: <1447869311-21955-1-git-send-email-abbotti@mev.co.uk>
In-Reply-To: <1447869311-21955-1-git-send-email-abbotti@mev.co.uk>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2015 17:23:51.8572
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0101MB1060
X-Microsoft-Exchange-Diagnostics: 1;BN3PR0101MB1171;2:4KsSbdct/2Ggs9xyjyKfKuN0RAoQozcUXyCIWLXD/gAciixrxfPf47OZ8tE0SdTMzNnfeI6gD07MlJhxVIU4iM0LHd/FiHAQ50Qjx3t8CG6IHMno206RXbME4j+nJsBtcBlWeUb8/ivbH65b1y91oNJU9nh7251oTJ3N3gMeU3Y=;23:AjvkOzSgu74lSJw4OEUuJ1dzJ1rJYkwni3DhNTCE2Vc605aaCw7z9bPN6FovDYUiBLBe2+aB7wVvZ/KtIVdZwc5CW1jVcfO1mvvrskct0VjuBv2RAtVh7nkhXsL5+IQXCimK556PxPZhpD1CWa2sfh0Q/3PVVWMY+OFEqcxLy8H5bxyf0qt4W/Ee6uMDAYzS
X-OriginatorOrg: visionengravers.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1359
Lines: 32

On Wednesday, November 18, 2015 10:55 AM, Ian Abbott wrote:
> Tidy up the "write" file operation handler, `comedi_write()` a bit and
> improve the error handling.
>
> 1) staging: comedi: rearrange comedi_write() code
> 2) staging: comedi: do extra checks for becoming non-busy for "write"
> 3) staging: comedi: make some variables unsigned in comedi_write()
> 4) staging: comedi: avoid bad truncation of a size_t in comedi_write()
> 5) staging: comedi: allow buffer wraparound in comedi_write()
> 6) staging: comedi: return error on "write" if no command set up
> 7) staging: comedi: simplify returned errors for comedi_write()
> 8) staging: comedi: check for more errors for zero-length write
>
>  drivers/staging/comedi/comedi_fops.c | 124 ++++++++++++++++-------------------
>  1 file changed, 56 insertions(+), 68 deletions(-)

Ian,

Other than the minor nit-pick in patch 1 about the 'count == 0'
when becoming non-busy (the same situation is in comedi_read),
this looks good to me. It also makes the 'write' look more like the
'read'.

Thanks,

Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/