Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757221AbbKSRek (ORCPT ); Thu, 19 Nov 2015 12:34:40 -0500 Received: from mail-bl2on0141.outbound.protection.outlook.com ([65.55.169.141]:25202 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752147AbbKSRei convert rfc822-to-8bit (ORCPT ); Thu, 19 Nov 2015 12:34:38 -0500 From: Hartley Sweeten To: Ian Abbott , "driverdev-devel@linuxdriverproject.org" CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 0/2] staging: comedi: s526: add counter register macros Thread-Topic: [PATCH 0/2] staging: comedi: s526: add counter register macros Thread-Index: AQHRItl5fMVIlGzSE0WFLAsNC3ENk56jmyFg Date: Thu, 19 Nov 2015 17:34:35 +0000 Message-ID: References: <1447944548-25850-1-git-send-email-abbotti@mev.co.uk> In-Reply-To: <1447944548-25850-1-git-send-email-abbotti@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=HartleyS@visionengravers.com; x-originating-ip: [184.183.19.121] x-microsoft-exchange-diagnostics: 1;BN3PR0101MB1058;5:OzuBg7KVCcdylHp+drTWAP94r0wKpZzXBaLH923vRueqvlr++ONlNPa8p+zuWTRNk540xybz+qV68riPjxEF9oDyr7sgCoLuUhc5YZ3/3qLpSIqaZMtGqimtOLFDCM0vmaTfSj6kvOCQ3hc3C9VFsw==;24:1xGg8vObXoENLWcNPS/yDubjnPfRDWKhPl5B0rsVFVBnDHM8BVsU81JfMiOSu2PvNrIYEvDnmyKeK/iUbZkcquU4thnKd5+ekcZbV4IBcMg=;20:+/Kp79XJxopd89eY2OJrfXjfIkgsjjMVSLhkiZOSlBkfocLMWit0njS+N69a4njA+yIjq9AZHj+yjjMy/Q6NLw== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0101MB1058; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(156620851176556); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001);SRVR:BN3PR0101MB1058;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0101MB1058; x-forefront-prvs: 07658B8EA3 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(189002)(199003)(24454002)(10400500002)(50986999)(105586002)(54356999)(5008740100001)(74316001)(87936001)(19580405001)(19580395003)(106356001)(586003)(77096005)(66066001)(92566002)(2950100001)(86362001)(81156007)(80792005)(11100500001)(5004730100002)(5002640100001)(2900100001)(97736004)(122556002)(106116001)(3846002)(40100003)(33656002)(76176999)(102836003)(5001960100002)(189998001)(5001920100001)(2501003)(5003600100002)(101416001)(5001770100001)(6116002)(5007970100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0101MB1058;H:BN3PR0101MB1057.prod.exchangelabs.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visionengravers.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2015 17:34:35.7206 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0101MB1058 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 868 Lines: 20 On Thursday, November 19, 2015 7:49 AM, Ian Abbott wrote: > Add macros to describe the counter mode and counter control/status > registers. In patch 1, the macros for the counter mode register replace > the use of bitfield structure and union types. > > 1) staging: comedi: s526: replace counter mode bitfield struct > 2) staging: comedi: s526: add macros for counter control reg values > > drivers/staging/comedi/drivers/s526.c | 197 ++++++++++++++++++++++------------ > 1 file changed, 130 insertions(+), 67 deletions(-) Thanks! This one has bugged me. Reviewed-by: H Hartley Sweeten -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/