Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759287AbbKSU1t (ORCPT ); Thu, 19 Nov 2015 15:27:49 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:33028 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754580AbbKSU1r (ORCPT ); Thu, 19 Nov 2015 15:27:47 -0500 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , Simon Horman , Magnus Damm , Yoshinori Sato , Laurent Pinchart , linux-serial@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 01/25] serial: sh-sci: Update DT binding documentation for external clock input Date: Thu, 19 Nov 2015 22:27:55 +0200 Message-ID: <2241755.f72hngpPkv@avalon> User-Agent: KMail/4.14.8 (Linux/4.0.9-gentoo; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1756365.Ijac5ApxcA@avalon> References: <1447958344-836-1-git-send-email-geert+renesas@glider.be> <1447958344-836-2-git-send-email-geert+renesas@glider.be> <1756365.Ijac5ApxcA@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2033 Lines: 53 Hi Geert, On Thursday 19 November 2015 22:19:14 Laurent Pinchart wrote: > On Thursday 19 November 2015 19:38:40 Geert Uytterhoeven wrote: > > Amend the DT bindings to include the optional external clock on > > (H)SCI(F) and some SCIFA, where this pin can serve as a clock input, > > depending on board wiring. > > > > Signed-off-by: Geert Uytterhoeven > > Cc: devicetree@vger.kernel.org > > --- > > > > Documentation/devicetree/bindings/serial/renesas,sci-serial.txt | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt > > b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt index > > 2c9e6b8477e92792..8efc9b6f35637fbb 100644 > > --- a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt > > +++ b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt > > > > @@ -43,6 +43,9 @@ Required properties: > > - clocks: Must contain a phandle and clock-specifier pair for each > > entry > > > > in clock-names. > > > > - clock-names: Must contain "fck" for the SCIx UART functional clock. > > > > + On (H)SCI(F) and some SCIFA, an additional clock may be specified: > Could you list the SCIFA variants that support external clocks ? > > > + - "hsck" for the optional external clock input (on HSCIF), > > + - "sck" for the optional external clock input (on other variants). Additionally, those clocks are used as inputs to the baud rate generator for external clocks, as the ones listed in patch 02/25 in this series. I'd merge the two patches and clarify the wording. > > Note: Each enabled SCIx UART should have an alias correctly numbered in > > the "aliases" node. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/