Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161384AbbKSUtL (ORCPT ); Thu, 19 Nov 2015 15:49:11 -0500 Received: from mail-ob0-f173.google.com ([209.85.214.173]:35742 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934448AbbKSUtH (ORCPT ); Thu, 19 Nov 2015 15:49:07 -0500 MIME-Version: 1.0 In-Reply-To: <1636784.2d3bsCa4Hn@avalon> References: <1447958344-836-1-git-send-email-geert+renesas@glider.be> <1447958344-836-9-git-send-email-geert+renesas@glider.be> <1636784.2d3bsCa4Hn@avalon> Date: Thu, 19 Nov 2015 21:49:05 +0100 X-Google-Sender-Auth: EadGai3-YHYoVbfoh1BcW8TK0EE Message-ID: Subject: Re: [PATCH 08/25] serial: sh-sci: Make unsigned values in sci_baud_calc_hscif() unsigned From: Geert Uytterhoeven To: Laurent Pinchart Cc: Geert Uytterhoeven , Greg Kroah-Hartman , Simon Horman , Magnus Damm , Yoshinori Sato , "linux-serial@vger.kernel.org" , Linux-sh list , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1751 Lines: 38 On Thu, Nov 19, 2015 at 9:36 PM, Laurent Pinchart wrote: >> --- a/drivers/tty/serial/sh-sci.c >> +++ b/drivers/tty/serial/sh-sci.c >> @@ -1880,9 +1881,9 @@ static void sci_baud_calc_hscif(unsigned int bps, >> unsigned long freq, int *brr, for (c = 0; c <= 3; c++) { >> /* integerized formulas from HSCIF documentation */ >> br = DIV_ROUND_CLOSEST(freq, (sr * >> - (1 << (2 * c + 1)) * bps)) - 1; >> - br = clamp(br, 0, 255); >> - err = DIV_ROUND_CLOSEST(freq, ((br + 1) * bps * sr * >> + (1 << (2 * c + 1)) * bps)); >> + br = clamp(br, 1U, 256U); >> + err = DIV_ROUND_CLOSEST(freq, (br * bps * sr * >> (1 << (2 * c + 1)) / 1000)) - >> 1000; > > While you're at it you can remove the parentheses around the second argument > to DIV_ROUND_CLOSEST, they're not needed. The factor between parentheses is removed in the next patch. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/