Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161351AbbKSWSL (ORCPT ); Thu, 19 Nov 2015 17:18:11 -0500 Received: from mail-lf0-f47.google.com ([209.85.215.47]:33750 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934293AbbKSWSJ (ORCPT ); Thu, 19 Nov 2015 17:18:09 -0500 MIME-Version: 1.0 In-Reply-To: <20151119182433.GB24773@dtor-ws> References: <1447936001-21420-1-git-send-email-irina.tirdea@intel.com> <1447936001-21420-5-git-send-email-irina.tirdea@intel.com> <20151119182433.GB24773@dtor-ws> Date: Thu, 19 Nov 2015 23:18:06 +0100 X-Google-Sender-Auth: 716e9bl9OxOszQHVDhxlftyIsPU Message-ID: Subject: Re: [PATCH v11 4/8] Input: goodix - add power management support From: "Rafael J. Wysocki" To: Dmitry Torokhov Cc: Irina Tirdea , "Rafael J. Wysocki" , Bastien Nocera , Aleksei Mamlin , Karsten Merker , linux-input@vger.kernel.org, Mark Rutland , Rob Herring , Octavian Purdila , Linux Kernel Mailing List , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1383 Lines: 43 Hi, On Thu, Nov 19, 2015 at 7:24 PM, Dmitry Torokhov wrote: > On Thu, Nov 19, 2015 at 02:26:37PM +0200, Irina Tirdea wrote: >> Implement suspend/resume for goodix driver. >> [cut] >> >> +static int __maybe_unused goodix_suspend(struct device *dev) >> +{ >> + struct i2c_client *client = to_i2c_client(dev); >> + struct goodix_ts_data *ts = i2c_get_clientdata(client); >> + int error; >> + >> + /* We need gpio pins to suspend/resume */ >> + if (!ts->gpiod_int || !ts->gpiod_rst) >> + return 0; >> + >> + wait_for_completion(&ts->firmware_loading_complete); > > This is not that nice as it may lead to angry splats from the PM core if > firmware loading takes too long and we start suspending before it > completes. What exactly do you mean? The suspend watchdog or something else? > Rafael, if we issue pm_stay_awake() before requesting firmware and > pm_relax() once it is done, will this prevent the current suspend > timeouts? pm_stay_awake() only works if the checking of wakeup sources is enabled which generally depends on what user space does. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/