Date: Thu, 19 Nov 2015 15:41:24 -0800
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        John Stultz <john.stultz@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Len Brown <len.brown@intel.com>,
        Rafael Wysocki <rafael.j.wysocki@intel.com>,
        Eduardo Valentin <edubezval@gmail.com>, Paul Turner <pjt@google.com>,
        Josh Triplett <josh@joshtriplett.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH 2/4] timer: relax tick stop in idle entry
Message-ID: <20151119154124.6ffa0cec@icelake>
In-Reply-To: <20151119195905.GR3816@twins.programming.kicks-ass.net>
References: <1447444387-23525-1-git-send-email-jacob.jun.pan@linux.intel.com>
	<1447444387-23525-3-git-send-email-jacob.jun.pan@linux.intel.com>
	<alpine.DEB.2.11.1511131516180.3987@nanos>
	<20151113142438.3144d47d@icelake>
	<alpine.DEB.2.11.1511161558550.3761@nanos>
	<20151116135126.5a50e45d@icelake>
	<alpine.DEB.2.11.1511162255430.3761@nanos>
	<20151116160910.3811c8ca@icelake>
	<20151119190630.GP3816@twins.programming.kicks-ass.net>
	<20151119112125.743f12d7@icelake>
	<20151119195905.GR3816@twins.programming.kicks-ass.net>
Organization: OTC
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1153
Lines: 30

On Thu, 19 Nov 2015 20:59:05 +0100
Peter Zijlstra <peterz@infradead.org> wrote:

> On Thu, Nov 19, 2015 at 11:21:25AM -0800, Jacob Pan wrote:
> > On Thu, 19 Nov 2015 20:06:30 +0100
> > Peter Zijlstra <peterz@infradead.org> wrote:
> >   
> > > Which one? That is, I cannot find a idle_cpu() call from
> > > tick_nohz_irq_exit().  
> > it is  tick_irq_exit(void), i will not call tick_nohz_irq_exit() if
> > !idle_cpu()  
> 
> Ah, but I think we really only need to test for the idle task there,
> the && need_resched() part of that function takes care of the rest.
> 
> Once we have need_resched() set, we'll be on our way to
> tick_nohz_idle_exit() to restart the tick again.
Tested, it did the trick also. has less impact than changing idle_cpu().

My other point is the callers of idle_cpu() will see it returns false
but in forced idle. Can't see anything bad since we skip load balance.

Thanks, 

Jacob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/