Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934976AbbKSXni (ORCPT ); Thu, 19 Nov 2015 18:43:38 -0500 Received: from down.free-electrons.com ([37.187.137.238]:54570 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934846AbbKSXne (ORCPT ); Thu, 19 Nov 2015 18:43:34 -0500 Date: Fri, 20 Nov 2015 00:43:31 +0100 From: Maxime Ripard To: Timo Sigurdsson Cc: wens@csie.org, tyler.baker@linaro.org, info@gerhard-bertelsmann.de, plaes@plaes.org, rafael.j.wysocki@intel.com, linux@arm.linux.org.uk, carlo@caione.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH] ARM: sunxi: Re-enable SID driver in sunxi_defconfig Message-ID: <20151119234331.GT32142@lukather> References: <1447724578-4786-1-git-send-email-public_timo.s@silentcreek.de> <1447969715.1730.5.camel@silentcreek.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8+OS07CeIgZ706fH" Content-Disposition: inline In-Reply-To: <1447969715.1730.5.camel@silentcreek.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4183 Lines: 125 --8+OS07CeIgZ706fH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Nov 19, 2015 at 10:48:35PM +0100, Timo Sigurdsson wrote: > Hi Maxime, > Hi Chen-Yu, >=20 > Am Dienstag, den 17.11.2015, 02:42 +0100 schrieb Timo Sigurdsson: > > Commit 3d0b16a66c8a ("nvmem: sunxi: Move the SID driver to the nvmem > > framework") moved the the sunxi SID driver to a new framework, but left > > sunxi_defconfig with the deprecated config symbol EEPROM_SUNXI_SID > > instead of the new symbold NVMEM_SUNXI_SID. Hence, re-enable the driver > > in sunxi_defconfig. > >=20 > > While at it, clean up sunxi_defconfig by generating a fresh file via > > make sunxi_defconfig > > make savedefconfig > > While this moves around a few lines and removes unnecessary symbols, > > it doesn't introduce any functional changes. > >=20 > > Signed-off-by: Timo Sigurdsson > >=20 > > diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_= defconfig > > index 3c36e16..904ea52 100644 > > --- a/arch/arm/configs/sunxi_defconfig > > +++ b/arch/arm/configs/sunxi_defconfig > > @@ -11,14 +11,12 @@ CONFIG_SMP=3Dy > > CONFIG_NR_CPUS=3D8 > > CONFIG_AEABI=3Dy > > CONFIG_HIGHMEM=3Dy > > -CONFIG_HIGHPTE=3Dy > > CONFIG_ARM_APPENDED_DTB=3Dy > > CONFIG_ARM_ATAG_DTB_COMPAT=3Dy > > CONFIG_CPU_FREQ=3Dy > > CONFIG_CPUFREQ_DT=3Dy > > CONFIG_VFP=3Dy > > CONFIG_NEON=3Dy > > -CONFIG_PM=3Dy > > CONFIG_NET=3Dy > > CONFIG_PACKET=3Dy > > CONFIG_UNIX=3Dy > > @@ -37,7 +35,6 @@ CONFIG_CAN_SUN4I=3Dy > > # CONFIG_WIRELESS is not set > > CONFIG_DEVTMPFS=3Dy > > CONFIG_DEVTMPFS_MOUNT=3Dy > > -CONFIG_EEPROM_SUNXI_SID=3Dy > > CONFIG_BLK_DEV_SD=3Dy > > CONFIG_ATA=3Dy > > CONFIG_AHCI_SUNXI=3Dy > > @@ -63,11 +60,10 @@ CONFIG_STMMAC_ETH=3Dy > > # CONFIG_INPUT_MOUSEDEV is not set > > # CONFIG_INPUT_KEYBOARD is not set > > # CONFIG_INPUT_MOUSE is not set > > -CONFIG_INPUT_MISC=3Dy > > -CONFIG_INPUT_AXP20X_PEK=3Dy > > CONFIG_INPUT_TOUCHSCREEN=3Dy > > -CONFIG_KEYBOARD_SUN4I_LRADC=3Dy > > CONFIG_TOUCHSCREEN_SUN4I=3Dy > > +CONFIG_INPUT_MISC=3Dy > > +CONFIG_INPUT_AXP20X_PEK=3Dy > > CONFIG_SERIAL_8250=3Dy > > CONFIG_SERIAL_8250_CONSOLE=3Dy > > CONFIG_SERIAL_8250_NR_UARTS=3D8 > > @@ -123,6 +119,8 @@ CONFIG_PWM=3Dy > > CONFIG_PWM_SUN4I=3Dy > > CONFIG_PHY_SUN4I_USB=3Dy > > CONFIG_PHY_SUN9I_USB=3Dy > > +CONFIG_NVMEM=3Dy > > +CONFIG_NVMEM_SUNXI_SID=3Dy > > CONFIG_EXT4_FS=3Dy > > CONFIG_VFAT_FS=3Dy > > CONFIG_TMPFS=3Dy >=20 > Would you also prefer to see this patch split up into two patches (one > for re-enabling the SID driver and one for the extra cleanup of > sunxi_defconfg) as I was asked to do for my other patch for > multi_v7_defconfig? Yes, please do. Also why CONFIG_PM CONFIG_KEYBOARD_SUN4I_LRADC and CONFIG_HIGHPTE got removed ? Thanks, Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --8+OS07CeIgZ706fH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWTl6jAAoJEBx+YmzsjxAgb0wQAJLsWySiYEmncFoQzMtrToWo sKG27cw2IihURiaz25y53cgO4+9hPQ0wBM2OPYKpFU4oLwG54fkpWCMgn4B83Poi RGRy1wFolxu4SIPb682JdkVfSO1RdJtCXdWp8DS0gBt066CfqWvM1ScbXxgOkuWo 9qOtlOrQRWBipdpAe0dgzb9jEEkHimMjKdK3Kroxig2fJwb+w2mBemfcHti7dvxI riGigdXYf5l42zFyxjw5cp3Ix3qwTHiVnxKk4MXS6wz1KJIx5L/khJs5Q1n32ka+ iACCfM7stFM5xX66/0gT+llim/0rjweIui5/p48a2l+oKytOkSSOkX7hWzsHPsCq +cpBo73dmr/phFTU2je3CnW4MdC9FfuOye0N8BzTW6rxXfmQi4X+yY4bOA0bTmcA b279Yv5/lf1EU6lT/+A6SrdHY3pSftjiSm3Qyf5hBNi0KLenmEsTJXM930ocoaEU RIYZ/nyWGxUzxJgmKFeb+mvdVZyOMUv2sPSNCwMy4dFuz5g933sK55lQY9oDbS+j vlT5rgIESfAOAsenZGm551Az4T9p2lojIQIYXd1/+itHX6K/+imGM/x/1v+XrNzK pzOFQ8vnG3XNgEg0xJqEsQySdAq9dn6mVdce1XgvBmFfE7fomdipYRyjxnRtsuwc 2OAUK6/zklP/TDCA9WTm =BMhG -----END PGP SIGNATURE----- --8+OS07CeIgZ706fH-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/