Date: Fri, 20 Nov 2015 10:39:47 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
CC: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Andi Kleen <andi@firstfloor.org>, Kan Liang <kan.liang@intel.com>
Subject: Re: [PATCH v5 4/9] perf report: Add callchain value option
Message-ID: <20151120013947.GB23310@sejong>
References: <1447047946-1691-1-git-send-email-namhyung@kernel.org>
 <1447047946-1691-6-git-send-email-namhyung@kernel.org>
 <20151119135914.GB29361@kernel.org>
MIME-Version: 1.0
In-Reply-To: <20151119135914.GB29361@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2618
Lines: 76

On Thu, Nov 19, 2015 at 10:59:14AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Nov 09, 2015 at 02:45:41PM +0900, Namhyung Kim escreveu:
> > Now -g/--call-graph option supports how to display callchain values.
> > Possible values are 'percent', 'period' and 'count'.  The percent is
> > same as before and it's the default behavior.  The period displays the
> > raw period value rather than the percentage.  The count displays the
> > number of occurrences.
> > 
> >   $ perf report --no-children --stdio -g percent
> >   ...
> >     39.93%  swapper  [kernel.vmlinux]  [k] intel_idel
> >             |
> >             ---intel_idle
> >                cpuidle_enter_state
> >                cpuidle_enter
> >                call_cpuidle
> >                cpu_startup_entry
> >                |
> >                |--28.63%-- start_secondary
> >                |
> >                 --11.30%-- rest_init
> 
> So, if I try to do:
> 
>   perf report --no-children --stdio -g percent,count
> 
> It shows just 'count', i.e. the last of these options, is this an
> intended limitation?
> 
> I'm applying it as-is, but I can see no reason why we wouldn't want to
> lift this limitation.


Hmm.. I expected just one value type is used, but yes, we might want
to support to print multiple values if needed.

Thanks,
Namhyung


>  
> >   $ perf report --no-children --show-total-period --stdio -g period
> >   ...
> >     39.93%   13018705  swapper  [kernel.vmlinux]  [k] intel_idel
> >             |
> >             ---intel_idle
> >                cpuidle_enter_state
> >                cpuidle_enter
> >                call_cpuidle
> >                cpu_startup_entry
> >                |
> >                |--9334403-- start_secondary
> >                |
> >                 --3684302-- rest_init
> > 
> >   $ perf report --no-children --show-nr-samples --stdio -g count
> >   ...
> >     39.93%     80  swapper  [kernel.vmlinux]  [k] intel_idel
> >             |
> >             ---intel_idle
> >                cpuidle_enter_state
> >                cpuidle_enter
> >                call_cpuidle
> >                cpu_startup_entry
> >                |
> >                |--57-- start_secondary
> >                |
> >                 --23-- rest_init
> > 
> > Acked-by: Brendan Gregg <brendan.d.gregg@gmail.com>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/