Date: Fri, 20 Nov 2015 10:40:13 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
CC: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Andi Kleen <andi@firstfloor.org>, Kan Liang <kan.liang@intel.com>
Subject: Re: [PATCH v5 7/9] perf hists browser: Support folded callchains
Message-ID: <20151120014013.GC23310@sejong>
References: <1447047946-1691-1-git-send-email-namhyung@kernel.org>
 <1447047946-1691-9-git-send-email-namhyung@kernel.org>
 <20151119141938.GC29361@kernel.org>
MIME-Version: 1.0
In-Reply-To: <20151119141938.GC29361@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1392
Lines: 31

On Thu, Nov 19, 2015 at 11:19:38AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Nov 09, 2015 at 02:45:44PM +0900, Namhyung Kim escreveu:
> > The folded callchain mode is to print all chains in a single line.
> > Currently perf report --tui doesn't support folded callchains.  Like
> > flat callchains, only leaf nodes are added to the final rbtree so it
> > should show entries in parent nodes.  To do that, add flat_val list to
> > struct callchain_node and show them along with the (normal) val list.
> > 
> > For example, folded callchain looks like below:
> > 
> >   $ perf report -g folded --tui
> >   Samples: 234  of event 'cycles:pp', Event count (approx.): 32605268
> >     Overhead  Command  Shared Object     Symbol
> >   -   39.93%  swapper  [kernel.vmlinux]  [k] intel_idle
> >      + 28.63% intel_idle; cpuidle_enter_state; cpuidle_enter; ...
> >      + 11.30% intel_idle; cpuidle_enter_state; cpuidle_enter; ...
> 
> The +/- before the folded callchains continue toggling, but with no, a
> further polishment is to elide them altogether, since they have no use.
> 
> Applied, that can be done on top.

Agreed.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/