MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: 8BIT
Message-id: <564E8021.80406@samsung.com>
Date: Fri, 20 Nov 2015 11:06:25 +0900
From: Chanwoo Choi <cw00.choi@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.6.0
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: myungjoo.ham@samsung.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH v3 6/6] extcon: arizona: Update DT binding documentation
 for jack detection
References: <1447947940-3054-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
 <1447947940-3054-7-git-send-email-ckeepax@opensource.wolfsonmicro.com>
In-reply-to: <1447947940-3054-7-git-send-email-ckeepax@opensource.wolfsonmicro.com>
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1745
Lines: 41

Hi Charles,

On 2015년 11월 20일 00:45, Charles Keepax wrote:
> Add additional bindings for both inverting the polarity of the jack
> detection pins and allowing the use of a second jack detection pin. Note
> that the second jack detection pin is hard wired in the chip so can only
> be enabled through the binding, rather than a pin being specified.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  .../devicetree/bindings/extcon/extcon-arizona.txt  |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-arizona.txt b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> index d661811..7640a35 100644
> --- a/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> +++ b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> @@ -14,6 +14,12 @@ Optional properties:
>      If this node is not mentioned or if the value is unknown, then
>      headphone detection mode is set to HPDETL.
>  
> +  - wlf,use-jd-gpio : Use GPIO input along with JD1 for dual pin jack
> +    detection.

This property naming might cause the confusion.
If some don't know the knowledge of extcon-arizona,
it seems like the specific GPIO pin.

But I'll apply the all patches of this patchset
because these patchest take the too long time for review.

I'd like you to modify the this property name on later patch.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/