Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934695AbbKTHQS (ORCPT ); Fri, 20 Nov 2015 02:16:18 -0500 Received: from mail-yk0-f175.google.com ([209.85.160.175]:34919 "EHLO mail-yk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754165AbbKTHQQ (ORCPT ); Fri, 20 Nov 2015 02:16:16 -0500 MIME-Version: 1.0 In-Reply-To: <2997631.z1xUhmAZzM@avalon> References: <20151117031832.24924.60685.sendpatchset@little-apple> <2997631.z1xUhmAZzM@avalon> Date: Fri, 20 Nov 2015 16:16:15 +0900 Message-ID: Subject: Re: [PATCH 00/04] pinctrl: sh-pfc: r8a7794: DU support From: Magnus Damm To: Laurent Pinchart Cc: SH-Linux , Linus Walleij , linux-kernel , Koji Matsuoka , linux-gpio , "Simon Horman [Horms]" , geert@glider.be Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2139 Lines: 56 Hi Laurent, On Fri, Nov 20, 2015 at 11:46 AM, Laurent Pinchart wrote: > Hi Magnus, > > Thank you for the patch. > > On Tuesday 17 November 2015 12:18:32 Magnus Damm wrote: >> pinctrl: sh-pfc: r8a7794: DU support >> >> [PATCH 01/04] pinctrl: sh-pfc: r8a7794: Add DU pin groups >> [PATCH 02/04] pinctrl: sh-pfc: r8a7794: Separate DU CDE and DISP >> [PATCH 03/04] pinctrl: sh-pfc: r8a7794: Add missing dot clock signals >> [PATCH 04/04] pinctrl: sh-pfc: r8a7794: Break out ODDF from sync >> >> These patches take the r8a7794 PFC DU support code from the BSP >> and reworks it to fit the r8a7794 ALT board. Tested with the ALT >> VGA port - by default PFC is not used however enabling PFC using >> an incremental (yet to be posted) patch works well. >> >> It is worth noting that patch 2-4 modifies the pin groups. This >> means that the upstream DT ABI for PFC DU will differ compared >> to the unreviewed BSP code. >> >> In general it is not considered good practice to change the pin >> groups and break compatibility since they are part of the DT ABI. >> >> For this particular case upstream never have had PFC DU support >> for r8a7794, so treating the BSP bindings as experimental and >> migrate away seems reasonable. > > If we start considering DT bindings that never went upstream as stable we'll > have a big problem. I mean even bigger than the upstream DT bindings stability > problem :-) I'm not saying that local DT hacks should be considered stable, more that it as usual makes sense to follow upstream first with proper DT review process early on. >> Signed-off-by: Magnus Damm > > Wouldn't it make sense to merge the 4 patches together ? Yeah, I guess so. My feeling is also that it would be good to verify HDMI on ALT before commiting to DT bindings. Right now only one DU channel is tested. Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/