Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935010AbbKTHq2 (ORCPT ); Fri, 20 Nov 2015 02:46:28 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:35014 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934424AbbKTHqJ convert rfc822-to-8bit (ORCPT ); Fri, 20 Nov 2015 02:46:09 -0500 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\)) Subject: Re: [PATCH] KVM: x86: emulate: correct page fault error code for NoWrite instructions From: Nadav Amit In-Reply-To: Date: Fri, 20 Nov 2015 09:46:07 +0200 Cc: Paolo Bonzini , "linux-kernel@vger.kernel.org" , kvm Content-Transfer-Encoding: 8BIT Message-Id: <346BBAFD-80C9-4C26-89B7-0F9ECD5D1DA0@gmail.com> References: <1423472611-5104-1-git-send-email-pbonzini@redhat.com> To: Wanpeng Li X-Mailer: Apple Mail (2.3096.5) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 979 Lines: 24 Wanpeng Li wrote: > 2015-11-20 10:52 GMT+08:00 Wanpeng Li : >> Hi Paolo, >> 2015-02-09 17:03 GMT+08:00 Paolo Bonzini : >>> NoWrite instructions (e.g. cmp or test) never set the "write access" >>> bit in the error code, even if one of the operands is treated as a >>> destination. >> >> Sorry to reply to an old commit, btw, could you point out where in SDM >> describe above? > > I see. I don’t understand whether you still need my help, so to clarify: on a page-fault the error code should indicate whether the access was due to a write access. Previously KVM marked it as “write access” for instructions such as test and cmp that do not perform write. Nadav-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/