Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162145AbbKTI2g (ORCPT ); Fri, 20 Nov 2015 03:28:36 -0500 Received: from nasmtp01.atmel.com ([192.199.1.246]:31858 "EHLO DVREDG02.corp.atmel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1162094AbbKTI2e (ORCPT ); Fri, 20 Nov 2015 03:28:34 -0500 Subject: Re: [PATCH v2 1/2] mtd: nand: atmel_nand: constify atmel_nand_caps structures To: LABBE Corentin , , References: <1448005517-26004-1-git-send-email-clabbe.montjoie@gmail.com> <1448005517-26004-2-git-send-email-clabbe.montjoie@gmail.com> CC: , From: Josh Wu Message-ID: <564ED99A.2050502@atmel.com> Date: Fri, 20 Nov 2015 16:28:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1448005517-26004-2-git-send-email-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.168.5.13] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1470 Lines: 50 Hi, Corentin Thanks for the patch. On 11/20/2015 3:45 PM, LABBE Corentin wrote: > All atmel_nand_caps are never modified, consitify them. > > Signed-off-by: LABBE Corentin Acked-by: Josh Wu Best Regards, Josh Wu > --- > drivers/mtd/nand/atmel_nand.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c > index 583cdd9..475c938 100644 > --- a/drivers/mtd/nand/atmel_nand.c > +++ b/drivers/mtd/nand/atmel_nand.c > @@ -128,7 +128,7 @@ struct atmel_nand_host { > > struct atmel_nfc *nfc; > > - struct atmel_nand_caps *caps; > + const struct atmel_nand_caps *caps; > bool has_pmecc; > u8 pmecc_corr_cap; > u16 pmecc_sector_size; > @@ -2304,11 +2304,11 @@ static int atmel_nand_remove(struct platform_device *pdev) > return 0; > } > > -static struct atmel_nand_caps at91rm9200_caps = { > +static const struct atmel_nand_caps at91rm9200_caps = { > .pmecc_correct_erase_page = false, > }; > > -static struct atmel_nand_caps sama5d4_caps = { > +static const struct atmel_nand_caps sama5d4_caps = { > .pmecc_correct_erase_page = true, > }; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/