Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162229AbbKTIea (ORCPT ); Fri, 20 Nov 2015 03:34:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40990 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161128AbbKTIe1 (ORCPT ); Fri, 20 Nov 2015 03:34:27 -0500 Date: Fri, 20 Nov 2015 10:34:18 +0200 From: "Michael S. Tsirkin" To: Benjamin Herrenschmidt Cc: David Woodhouse , Andy Lutomirski , Christian Borntraeger , Paolo Bonzini , "linux-kernel@vger.kernel.org" , Martin Schwidefsky , Sebastian Ott , linux-s390 , Cornelia Huck , Joerg Roedel , Linux Virtualization , Christoph Hellwig , KVM Subject: Re: [PATCH v3 0/3] virtio DMA API core stuff Message-ID: <20151120102141-mutt-send-email-mst@redhat.com> References: <20151119153821-mutt-send-email-mst@redhat.com> <1447976286.145626.122.camel@infradead.org> <1447988199.3016.2.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1447988199.3016.2.camel@kernel.crashing.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 33 On Fri, Nov 20, 2015 at 01:56:39PM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2015-11-19 at 23:38 +0000, David Woodhouse wrote: > > > > I understand that POWER and other platforms don't currently have a > > clean way to indicate that certain device don't have translation. And I > > understand that we may end up with a *quirk* which ensures that the DMA > > API does the right thing (i.e. nothing) in certain cases. > > > > But we should *NOT* be involving the virtio device drivers in that > > quirk, in any way. And putting a feature bit in the virtio device > > itself doesn't seem at all sane either. > > > > Bear in mind that qemu-system-x86_64 currently has the *same* problem > > with assigned physical devices. It's claiming they're translated, and > > they're not. > > It's not that clear but yeah ... as I mentioned, I can't find a > way to do that quirk that won't break when we want to actually use > the iommu...? > > Ben. Yes, I am not at all sure we need a quirk for assigned devices. Better teach QEMU to make iommu work for them. -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/