Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162052AbbKTI1M (ORCPT ); Fri, 20 Nov 2015 03:27:12 -0500 Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]:36712 "EHLO tama500.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759016AbbKTI1K (ORCPT ); Fri, 20 Nov 2015 03:27:10 -0500 Date: Fri, 20 Nov 2015 17:40:05 +0900 From: Takuya Yoshikawa To: pbonzini@redhat.com Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mtosatti@redhat.com, guangrong.xiao@linux.intel.com Subject: [PATCH V3 00/10] KVM: x86: MMU: Clean up x86's mmu code for future work Message-Id: <20151120174005.9880b89f54eee2cec2422da5@lab.ntt.co.jp> X-Mailer: Sylpheed 3.4.2 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2743 Lines: 57 It seems like you all are busy now, so I've made this patch set so that mechanical and trivial changes come before. V2->V3: Patch 01: Rebased and moved here. Updated stale comments. We may also want to use a union, inside the struct, to eliminate casting to (u64 *) type when spte is in the head in the future. Patch 02-05: No change. About patch 03: There was a comment on the usage of braces for a single line else-if statement from Xiao. As I answered, checkpatch did not complain about this, and when the corresponding if block has multiple lines, some developers prefer/recommend this style. Feel free to modify it if you don't like it. Patch 06: Changed WARN_ON to BUG_ON as Marcelo suggested. Patch 07: Removed unnecessary zero-initialization of sp->parent_ptes as Xiao suggested. I think these seven patches are ready for inclusion. Patch 08-10: No change now, though there were a few comments. This patch set is not intended to optimize anything, so these patches try to keep the way mark_unsync() gets called as much as possible: the only changes are when this gets called for the new parent_pte and when mmu_page_add_parent_pte() gets called. For these three, I'm not sure what we should do now, still RFC? We can also consider other approaches, e.g. moving link_shadow_page() in the kvm_get_mmu_page() as Paolo suggested before. Takuya Takuya Yoshikawa (10): [01] KVM: x86: MMU: Encapsulate the type of rmap-chain head in a new struct [02] KVM: x86: MMU: Remove unused parameter of __direct_map() [03] KVM: x86: MMU: Add helper function to clear a bit in unsync child bitmap [04] KVM: x86: MMU: Make mmu_set_spte() return emulate value [05] KVM: x86: MMU: Remove is_rmap_spte() and use is_shadow_present_pte() [06] KVM: x86: MMU: Consolidate BUG_ON checks for reverse-mapped sptes [07] KVM: x86: MMU: Move initialization of parent_ptes out from kvm_mmu_alloc_page() [08] KVM: x86: MMU: Use for_each_rmap_spte macro instead of pte_list_walk() [09] KVM: x86: MMU: Move parent_pte handling from kvm_mmu_get_page() to link_shadow_page() [10] KVM: x86: MMU: Remove unused parameter parent_pte from kvm_mmu_get_page() Documentation/virtual/kvm/mmu.txt | 4 +- arch/x86/include/asm/kvm_host.h | 8 +- arch/x86/kvm/mmu.c | 370 ++++++++++++++++++-------------------- arch/x86/kvm/mmu_audit.c | 15 +- arch/x86/kvm/paging_tmpl.h | 20 +-- 5 files changed, 201 insertions(+), 216 deletions(-) -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/