Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162084AbbKTJWM (ORCPT ); Fri, 20 Nov 2015 04:22:12 -0500 Received: from mail-ob0-f172.google.com ([209.85.214.172]:33999 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161167AbbKTJWE (ORCPT ); Fri, 20 Nov 2015 04:22:04 -0500 MIME-Version: 1.0 In-Reply-To: <1447273657-1668-1-git-send-email-clabbe.montjoie@gmail.com> References: <1447273657-1668-1-git-send-email-clabbe.montjoie@gmail.com> Date: Fri, 20 Nov 2015 10:22:02 +0100 X-Google-Sender-Auth: I2oYqe5KSDt3haPGnCMDqEx-v_0 Message-ID: Subject: Re: [PATCH 1/3] gpio: 74xx: fix a possible NULL dereference From: Geert Uytterhoeven To: LABBE Corentin Cc: Alexandre Courbot , Linus Walleij , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1962 Lines: 54 On Wed, Nov 11, 2015 at 9:27 PM, LABBE Corentin wrote: > of_match_device could return NULL, and so cause a NULL pointer > dereference later at line 132: > priv->flags = (uintptr_t) of_id->data; > > Reported-by: coverity (CID 1324141) This is a DT-only driver, hence this cannot happen? > Signed-off-by: LABBE Corentin > --- > drivers/gpio/gpio-74xx-mmio.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-74xx-mmio.c b/drivers/gpio/gpio-74xx-mmio.c > index 6ed7c0f..6b18682 100644 > --- a/drivers/gpio/gpio-74xx-mmio.c > +++ b/drivers/gpio/gpio-74xx-mmio.c > @@ -113,13 +113,16 @@ static int mmio_74xx_dir_out(struct gpio_chip *gc, unsigned int gpio, int val) > > static int mmio_74xx_gpio_probe(struct platform_device *pdev) > { > - const struct of_device_id *of_id = > - of_match_device(mmio_74xx_gpio_ids, &pdev->dev); > + const struct of_device_id *of_id; > struct mmio_74xx_gpio_priv *priv; > struct resource *res; > void __iomem *dat; > int err; > > + of_id = of_match_device(mmio_74xx_gpio_ids, &pdev->dev); > + if (!of_id) > + return -ENODEV; > + > priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > if (!priv) > return -ENOMEM; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/