Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162167AbbKTJlx (ORCPT ); Fri, 20 Nov 2015 04:41:53 -0500 Received: from mga09.intel.com ([134.134.136.24]:64097 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964831AbbKTJlu (ORCPT ); Fri, 20 Nov 2015 04:41:50 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,321,1444719600"; d="scan'208";a="824882585" Subject: Re: [PATCH V3 00/10] KVM: x86: MMU: Clean up x86's mmu code for future work To: Takuya Yoshikawa , pbonzini@redhat.com References: <20151120174005.9880b89f54eee2cec2422da5@lab.ntt.co.jp> Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mtosatti@redhat.com From: Xiao Guangrong Message-ID: <564EE952.8070305@linux.intel.com> Date: Fri, 20 Nov 2015 17:35:14 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151120174005.9880b89f54eee2cec2422da5@lab.ntt.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1224 Lines: 28 On 11/20/2015 04:40 PM, Takuya Yoshikawa wrote: > It seems like you all are busy now, so I've made this patch set so that > mechanical and trivial changes come before. > > V2->V3: > Patch 01: Rebased and moved here. Updated stale comments. > We may also want to use a union, inside the struct, to eliminate casting to > (u64 *) type when spte is in the head in the future. > Patch 02-05: No change. > About patch 03: There was a comment on the usage of braces for a single line > else-if statement from Xiao. As I answered, checkpatch did not complain about > this, and when the corresponding if block has multiple lines, some developers > prefer/recommend this style. Feel free to modify it if you don't like it. > Patch 06: Changed WARN_ON to BUG_ON as Marcelo suggested. > Patch 07: Removed unnecessary zero-initialization of sp->parent_ptes as Xiao > suggested. > For patch 01 - patch 07: Reviewed-by: Xiao Guangrong -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/